<!--
Thanks for your interest in the project. Bugs filed and PRs submitted are appreciated!
Please make sure that you are familiar with and follow the Code of Conduct for
this project (found in the CODE_OF_CONDUCT.md file).
Also, please make sure you're familiar with and follow the instructions in the
contributing guidelines (found in the CONTRIBUTING.md file).
If you're new to contributing to open source projects, you might find this free
video course helpful: http://kcd.im/pull-request
Please fill out the information below to expedite the review and (hopefully)
merge of your pull request!
-->
<!-- What changes are being made? (What feature/bug is being fixed here?) -->
**What**:
Add Security contribution type, as mentioned in https://github.com/kentcdodds/all-contributors/issues/106 and implemented in https://github.com/kentcdodds/all-contributors/pull/107
Also added user-testing as introduced as part of https://github.com/kentcdodds/all-contributors/pull/97/files
<!-- Why are these changes necessary? -->
**Why**:
All contributors!
<!-- How were these changes implemented? -->
**How**:
Me
<!-- Have you done all of these things? -->
**Checklist**:
<!-- add "N/A" to the end of each line that's irrelevant to your changes -->
<!-- to check an item, place an "x" in the box like so: "- [x] Documentation" -->
- [x] Documentation
- [ ] Tests - N/A
- [x] Ready to be merged <!-- In your opinion, is this ready to be merged as soon as it's reviewed? -->
- [x] Added myself to contributors table <!-- this is optional, see the contributing guidelines for instructions -->
<!-- feel free to add additional comments -->
<!--
Thanks for your interest in the project. Bugs filed and PRs submitted are appreciated!
Please make sure that you are familiar with and follow the Code of Conduct for
this project (found in the CODE_OF_CONDUCT.md file).
Also, please make sure you're familiar with and follow the instructions in the
contributing guidelines (found in the CONTRIBUTING.md file).
If you're new to contributing to open source projects, you might find this free
video course helpful: http://kcd.im/pull-request
Please fill out the information below to expedite the review and (hopefully)
merge of your pull request!
-->
<!-- What changes are being made? (What feature/bug is being fixed here?) -->
**What**:
When a config file is loaded, but the contents cannot be parsed to JSON an error will be thrown. Instead of failing silent: e.g.:
<img width="735" alt="screen shot 2018-12-23 at 5 04 17 pm" src="https://user-images.githubusercontent.com/3534236/50382208-026cdb80-06d5-11e9-8f4d-8d97a9a3cbe1.png">
<!-- Why are these changes necessary? -->
**Why**:
Previously some commands would crash randomly. e.g. `add` with `Cannot read property 'then' of null`.
While other commands e.g. `generate` would succeed but would blow away all your contributors (because it didn't find any)
<!-- How were these changes implemented? -->
**How**:
By Me
<!-- Have you done all of these things? -->
**Checklist**:
<!-- add "N/A" to the end of each line that's irrelevant to your changes -->
<!-- to check an item, place an "x" in the box like so: "- [x] Documentation" -->
- [ ] Documentation N/A
- [ ] Tests N/A
- [x] Ready to be merged <!-- In your opinion, is this ready to be merged as soon as it's reviewed? -->
- [ ] Added myself to contributors table <!-- this is optional, see the contributing guidelines for instructions -->
<!-- feel free to add additional comments -->
<!--
Thanks for your interest in the project. Bugs filed and PRs submitted are appreciated!
Please make sure that you are familiar with and follow the Code of Conduct for
this project (found in the CODE_OF_CONDUCT.md file).
Also, please make sure you're familiar with and follow the instructions in the
contributing guidelines (found in the CONTRIBUTING.md file).
If you're new to contributing to open source projects, you might find this free
video course helpful: http://kcd.im/pull-request
Please fill out the information below to expedite the review and (hopefully)
merge of your pull request!
-->
<!-- What changes are being made? (What feature/bug is being fixed here?) -->
**What**:
Add a way to avoid GITHUB API LIMIT by supplying an optional GITHUB_AUTH token to increase github rate limiting from 50 requests to 5000 (and limited by user, not IP)
<!-- Why are these changes necessary? -->
**Why**:
To address: #121
<!-- How were these changes implemented? -->
**How**:
By Me
<!-- Have you done all of these things? -->
**Checklist**:
<!-- add "N/A" to the end of each line that's irrelevant to your changes -->
<!-- to check an item, place an "x" in the box like so: "- [x] Documentation" -->
- [ ] Documentation
- [ ] Tests
- [ ] Ready to be merged <!-- In your opinion, is this ready to be merged as soon as it's reviewed? -->
- [ ] Added myself to contributors table <!-- this is optional, see the contributing guidelines for instructions -->
<!-- feel free to add additional comments -->
<!--
Thanks for your interest in the project. Bugs filed and PRs submitted are appreciated!
Please make sure that you are familiar with and follow the Code of Conduct for
this project (found in the CODE_OF_CONDUCT.md file).
Also, please make sure you're familiar with and follow the instructions in the
contributing guidelines (found in the CONTRIBUTING.md file).
If you're new to contributing to open source projects, you might find this free
video course helpful: http://kcd.im/pull-request
Please fill out the information below to expedite the review and (hopefully)
merge of your pull request!
-->
<!-- What changes are being made? (What feature/bug is being fixed here?) -->
**What**: remove unnecessary space
<!-- Why are these changes necessary? -->
**Why**: generate command will not generate files because of extra space
<!-- How were these changes implemented? -->
**How**: remove space
<!-- Have you done all of these things? -->
**Checklist**:
<!-- add "N/A" to the end of each line that's irrelevant to your changes -->
<!-- to check an item, place an "x" in the box like so: "- [x] Documentation" -->
- [x] Documentation
- [x] Tests
- [ ] Ready to be merged <!-- In your opinion, is this ready to be merged as soon as it's reviewed? -->
- [ ] Added myself to contributors table <!-- this is optional, see the contributing guidelines for instructions -->
<!-- feel free to add additional comments -->
<!--
Thanks for your interest in the project. Bugs filed and PRs submitted are appreciated!
Please make sure that you are familiar with and follow the Code of Conduct for
this project (found in the CODE_OF_CONDUCT.md file).
Also, please make sure you're familiar with and follow the instructions in the
contributing guidelines (found in the CONTRIBUTING.md file).
If you're new to contributing to open source projects, you might find this free
video course helpful: http://kcd.im/pull-request
Please fill out the information below to expedite the review and (hopefully)
merge of your pull request!
-->
<!-- What changes are being made? (What feature/bug is being fixed here?) -->
**What**: Add a couple of sentences about running the from the command line with `npx` - they're almost verbetim the "heads up" that @kentcdodds suggested in https://github.com/jfmengels/all-contributors-cli/issues/92#issuecomment-391766876..
<!-- Why are these changes necessary? -->
**Why**: I was having difficulty understanding how to run the commands and I found this text in issue #92 super helpful - I figured it would be for others too 😄
<!-- How were these changes implemented? -->
**How**: Updated text in README
<!-- Have you done all of these things? -->
**Checklist**:
<!-- add "N/A" to the end of each line that's irrelevant to your changes -->
<!-- to check an item, place an "x" in the box like so: "- [x] Documentation" -->
- [x] Documentation
- [ ] Tests -- NA
- [x] Ready to be merged <!-- In your opinion, is this ready to be merged as soon as it's reviewed? -->
- [ ] Added myself to contributors table -- ironically I'm not sure how to do this 🤣 <!-- this is optional, see the contributing guidelines for instructions -->
<!-- feel free to add additional comments -->
<!--
Thanks for your interest in the project. Bugs filed and PRs submitted are appreciated!
Please make sure that you are familiar with and follow the Code of Conduct for
this project (found in the CODE_OF_CONDUCT.md file).
Also, please make sure you're familiar with and follow the instructions in the
contributing guidelines (found in the CONTRIBUTING.md file).
If you're new to contributing to open source projects, you might find this free
video course helpful: http://kcd.im/pull-request
Please fill out the information below to expedite the review and (hopefully)
merge of your pull request!
-->
<!-- What changes are being made? (What feature/bug is being fixed here?) -->
**What**:
Without the space, it looks like a little strange.
<!-- Why are these changes necessary? -->
**Why**:
<!-- How were these changes implemented? -->
**How**:
<!-- Have you done all of these things? -->
**Checklist**:
<!-- add "N/A" to the end of each line that's irrelevant to your changes -->
<!-- to check an item, place an "x" in the box like so: "- [x] Documentation" -->
- [ ] Documentation
- [ ] Tests
- [x] Ready to be merged <!-- In your opinion, is this ready to be merged as soon as it's reviewed? -->
- [ ] Added myself to contributors table <!-- this is optional, see the contributing guidelines for instructions -->
<!-- feel free to add additional comments -->
* adds helpful error message when files is overridden or empty
* fix: d4dc4e2-introduced error
The prior commit to this branch d4dc4e2 introduced an error
in the util/config.js file where it checks for the length of
the content.files property, whether that property exists in
the config or not.
* initial issue fix
* tests added
* revert unneisary lint change to untouched file
* added myself
* no contribution types when adding a contributor error handled
* revert commit 1bdb51eadf
* reverted readme back to commit# f697c73c48
* further reverted Readme to master
* removed generated index from rm
* removed generated index from rm
* breaking change to cli fixed:
* Update prompt.js
* Update prompt.js
* added code and test in my contribution
* list of invalid contributions added in error message
Closes#71
* error message when no project name and project owner is added in the init command
* moved error message away from init prompt
* 1. placed json parse in try catch
2. added check for owner and name in getcontributionsfromgithub before constructing url
* added check before config file is written
* changes as per https://github.com/jfmengels/all-contributors-cli/pull/80#pullrequestreview-85678121
* uncommented code
* tests added
* Added myself to contributors table
* test inside utils were moved to github in master branch
* changes to validation check, instead of checking for empty string to null obj value
* typo fixed
* unnecisary check.js file removed
* Change script name and add yarn
The script name suggested (`add`) will conflict with users of yarn.
So I modified the suggested name to `append` which is what it does. And now it can have a yarn example as well.
* remove yarn example
* namespace add
* feat: Add checking functionnality that compares contributors with GH data
* fix(check): Use the info from config file, paginate GH data
* doc(check): Document the new check command
* fix(eslint): Add missing semicolon
* tests: Add tests for utils.check
* fix: Check for code and test only
* refactor: use includes and correct awaits
* refactor: more includes and template literals
