mirror of
https://github.com/renovatebot/renovate.git
synced 2025-01-12 15:06:27 +00:00
fix: remove statusCheckVerify option (#7094)
Closes #7057 BREAKING CHANGE: statusCheckVerify config option is no longer supported and will be ignored
This commit is contained in:
Sergio Zharinov
GitHub
parent
838996dbe0
commit
0701419d6e
11 changed files with 1 additions and 93 deletions
|
|
@ -1479,10 +1479,6 @@ If you combine `stabilityDays=3` and `prCreation="not-pending"` then Renovate wi
|
|||
|
||||
If you have both `automerge` as well as `stabilityDays` enabled, it means that PRs will be created immediately but automerging will be delayed until X days have passed. This works because Renovate will add a "renovate/stability-days" pending status check to each branch/PR and that pending check will prevent the branch going green to automerge.
|
||||
|
||||
## statusCheckVerify
|
||||
|
||||
This feature is added for people migrating from alternative services who are used to seeing a "verify" status check on PRs. If you'd like to use this then go ahead, but otherwise it's more secure to look for Renovate's [GPG Verified Commits](https://github.com/blog/2144-gpg-signature-verification) instead, because those cannot be spoofed by any other person or service (unlike status checks).
|
||||
|
||||
## supportPolicy
|
||||
|
||||
Language support is limited to those listed below:
|
||||
|
|
|
|||
|
|
@ -54,7 +54,6 @@ export interface RenovateSharedConfig {
|
|||
semanticCommits?: boolean;
|
||||
semanticCommitScope?: string;
|
||||
semanticCommitType?: string;
|
||||
statusCheckVerify?: boolean;
|
||||
suppressNotifications?: string[];
|
||||
timezone?: string;
|
||||
unicodeEmoji?: boolean;
|
||||
|
|
|
|||
|
|
@ -1103,12 +1103,6 @@ const options: RenovateOptions[] = [
|
|||
type: 'string',
|
||||
default: 'rebase',
|
||||
},
|
||||
{
|
||||
name: 'statusCheckVerify',
|
||||
description: 'Set a verify status check for all PRs',
|
||||
type: 'boolean',
|
||||
default: false,
|
||||
},
|
||||
{
|
||||
name: 'unpublishSafe',
|
||||
description: 'Set a status check for unpublish-safe upgrades',
|
||||
|
|
|
|||
|
|
@ -22,6 +22,7 @@ const removedOptions = [
|
|||
'groupCommitMessage',
|
||||
'groupPrTitle',
|
||||
'groupPrBody',
|
||||
'statusCheckVerify',
|
||||
'lazyGrouping',
|
||||
];
|
||||
|
||||
|
|
|
|||
|
|
@ -80,7 +80,6 @@ export interface Issue {
|
|||
}
|
||||
export type PlatformPrOptions = {
|
||||
azureAutoComplete?: boolean;
|
||||
statusCheckVerify?: boolean;
|
||||
gitLabAutomerge?: boolean;
|
||||
};
|
||||
export interface CreatePRConfig {
|
||||
|
|
|
|||
|
|
@ -243,53 +243,6 @@ Array [
|
|||
"method": "POST",
|
||||
"url": "https://api.github.com/repos/some/repo/issues/123/labels",
|
||||
},
|
||||
Object {
|
||||
"headers": Object {
|
||||
"accept": "application/vnd.github.v3+json",
|
||||
"accept-encoding": "gzip, deflate",
|
||||
"authorization": "token abc123",
|
||||
"host": "api.github.com",
|
||||
"user-agent": "https://github.com/renovatebot/renovate",
|
||||
},
|
||||
"method": "GET",
|
||||
"url": "https://api.github.com/repos/some/repo/commits/0d9c7726c3d628b7e28af234595cfd20febdbf8e/statuses",
|
||||
},
|
||||
Object {
|
||||
"body": "{\\"state\\":\\"success\\",\\"description\\":\\"Renovate verified pull request\\",\\"context\\":\\"renovate/verify\\",\\"target_url\\":\\"https://github.com/renovatebot/renovate\\"}",
|
||||
"headers": Object {
|
||||
"accept": "application/vnd.github.v3+json",
|
||||
"accept-encoding": "gzip, deflate",
|
||||
"authorization": "token abc123",
|
||||
"content-length": "149",
|
||||
"content-type": "application/json",
|
||||
"host": "api.github.com",
|
||||
"user-agent": "https://github.com/renovatebot/renovate",
|
||||
},
|
||||
"method": "POST",
|
||||
"url": "https://api.github.com/repos/some/repo/statuses/0d9c7726c3d628b7e28af234595cfd20febdbf8e",
|
||||
},
|
||||
Object {
|
||||
"headers": Object {
|
||||
"accept": "application/vnd.github.v3+json",
|
||||
"accept-encoding": "gzip, deflate",
|
||||
"authorization": "token abc123",
|
||||
"host": "api.github.com",
|
||||
"user-agent": "https://github.com/renovatebot/renovate",
|
||||
},
|
||||
"method": "GET",
|
||||
"url": "https://api.github.com/repos/some/repo/commits/some-branch/status",
|
||||
},
|
||||
Object {
|
||||
"headers": Object {
|
||||
"accept": "application/vnd.github.v3+json",
|
||||
"accept-encoding": "gzip, deflate",
|
||||
"authorization": "token abc123",
|
||||
"host": "api.github.com",
|
||||
"user-agent": "https://github.com/renovatebot/renovate",
|
||||
},
|
||||
"method": "GET",
|
||||
"url": "https://api.github.com/repos/some/repo/commits/0d9c7726c3d628b7e28af234595cfd20febdbf8e/statuses",
|
||||
},
|
||||
]
|
||||
`;
|
||||
|
||||
|
|
|
|||
|
|
@ -1580,22 +1580,6 @@ describe('platform/github', () => {
|
|||
number: 123,
|
||||
})
|
||||
.post('/repos/some/repo/issues/123/labels')
|
||||
.reply(200, [])
|
||||
.get(
|
||||
'/repos/some/repo/commits/0d9c7726c3d628b7e28af234595cfd20febdbf8e/statuses'
|
||||
)
|
||||
.reply(200, [])
|
||||
.get('/repos/some/repo/commits/some-branch/status')
|
||||
.reply(200, {
|
||||
object: { sha: 'some-sha' },
|
||||
})
|
||||
.post(
|
||||
'/repos/some/repo/statuses/0d9c7726c3d628b7e28af234595cfd20febdbf8e'
|
||||
)
|
||||
.reply(200, [])
|
||||
.get(
|
||||
'/repos/some/repo/commits/0d9c7726c3d628b7e28af234595cfd20febdbf8e/statuses'
|
||||
)
|
||||
.reply(200, []);
|
||||
await github.initRepo({ repository: 'some/repo', token: 'token' } as any);
|
||||
const pr = await github.createPr({
|
||||
|
|
@ -1604,7 +1588,6 @@ describe('platform/github', () => {
|
|||
prTitle: 'The Title',
|
||||
prBody: 'Hello world',
|
||||
labels: ['deps', 'renovate'],
|
||||
platformOptions: { statusCheckVerify: true },
|
||||
});
|
||||
expect(pr).toMatchSnapshot();
|
||||
expect(httpMock.getTrace()).toMatchSnapshot();
|
||||
|
|
|
|||
|
|
@ -1427,16 +1427,6 @@ export async function createPr({
|
|||
pr.displayNumber = `Pull Request #${pr.number}`;
|
||||
pr.branchName = branchName;
|
||||
await addLabels(pr.number, labels);
|
||||
if (platformOptions.statusCheckVerify) {
|
||||
logger.debug('Setting statusCheckVerify');
|
||||
await setBranchStatus({
|
||||
branchName,
|
||||
context: `renovate/verify`,
|
||||
description: `Renovate verified pull request`,
|
||||
state: BranchStatus.green,
|
||||
url: 'https://github.com/renovatebot/renovate',
|
||||
});
|
||||
}
|
||||
return pr;
|
||||
}
|
||||
|
||||
|
|
|
|||
|
|
@ -1002,7 +1002,6 @@ describe('platform/gitlab', () => {
|
|||
labels: [],
|
||||
platformOptions: {
|
||||
azureAutoComplete: false,
|
||||
statusCheckVerify: false,
|
||||
gitLabAutomerge: true,
|
||||
},
|
||||
});
|
||||
|
|
|
|||
|
|
@ -47,7 +47,6 @@ Array [
|
|||
"platformOptions": Object {
|
||||
"azureAutoComplete": false,
|
||||
"gitLabAutomerge": false,
|
||||
"statusCheckVerify": false,
|
||||
},
|
||||
"prBody": "This PR contains the following updates:\\n\\n| Package | Type | Update | Change |\\n|---|---|---|---|\\n| [dummy](https://dummy.com) ([source](https://github.com/renovateapp/dummy), [changelog](https://github.com/renovateapp/dummy/changelog.md)) | devDependencies | pin | \`1.0.0\` -> \`1.1.0\` |\\n\\n:pushpin: **Important**: Renovate will wait until you have merged this Pin PR before creating any *upgrade* PRs for the affected packages. Add the preset \`:preserveSemverRanges\` to your config if you instead don't wish to pin dependencies.\\n\\n---\\n\\n### Release Notes\\n\\n<details>\\n<summary>renovateapp/dummy</summary>\\n\\n### [\`v1.1.0\`](https://github.com/renovateapp/dummy/compare/v1.0.0...v1.1.0)\\n\\n[Compare Source](https://github.com/renovateapp/dummy/compare/v1.0.0...v1.1.0)\\n\\n</details>\\n\\n---\\n\\n### Renovate configuration\\n\\n:date: **Schedule**: \\"before 5am\\" in timezone some timezone.\\n\\n:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.\\n\\n:recycle: **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.\\n\\n:no_bell: **Ignore**: Close this PR and you won't be reminded about this update again.\\n\\n---\\n\\n - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box\\n\\n---\\n\\nThis PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).",
|
||||
"prTitle": "Update dependency dummy to v1.1.0",
|
||||
|
|
@ -78,7 +77,6 @@ Array [
|
|||
"platformOptions": Object {
|
||||
"azureAutoComplete": false,
|
||||
"gitLabAutomerge": false,
|
||||
"statusCheckVerify": false,
|
||||
},
|
||||
"prBody": "This PR contains the following updates:\\n\\n| Package | Type | Update | Change |\\n|---|---|---|---|\\n| [dummy](https://dummy.com) ([source](https://github.com/renovateapp/dummy), [changelog](https://github.com/renovateapp/dummy/changelog.md)) | devDependencies | minor | \`1.0.0\` -> \`1.1.0\` |\\n\\n---\\n\\n### Release Notes\\n\\n<details>\\n<summary>renovateapp/dummy</summary>\\n\\n### [\`v1.1.0\`](https://github.com/renovateapp/dummy/compare/v1.0.0...v1.1.0)\\n\\n[Compare Source](https://github.com/renovateapp/dummy/compare/v1.0.0...v1.1.0)\\n\\n</details>\\n\\n---\\n\\n### Renovate configuration\\n\\n:date: **Schedule**: \\"before 5am\\" (UTC).\\n\\n:vertical_traffic_light: **Automerge**: Enabled.\\n\\n:recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.\\n\\n:no_bell: **Ignore**: Close this PR and you won't be reminded about this update again.\\n\\n---\\n\\n - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box\\n\\n---\\n\\nThis PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).",
|
||||
"prTitle": "Update dependency dummy to v1.1.0",
|
||||
|
|
@ -96,7 +94,6 @@ Array [
|
|||
"platformOptions": Object {
|
||||
"azureAutoComplete": false,
|
||||
"gitLabAutomerge": false,
|
||||
"statusCheckVerify": false,
|
||||
},
|
||||
"prBody": "This PR contains the following updates:\\n\\n| Package | Type | Update | Change |\\n|---|---|---|---|\\n| [gitlabdummy](https://dummy.com) ([source](https://gitlab.com/renovateapp/gitlabdummy), [changelog](https://gitlab.com/renovateapp/gitlabdummy/changelog.md)) | devDependencies | minor | \`1.0.0\` -> \`1.1.0\` |\\n\\n---\\n\\n### Renovate configuration\\n\\n:date: **Schedule**: \\"before 5am\\" (UTC).\\n\\n:vertical_traffic_light: **Automerge**: Enabled.\\n\\n:recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.\\n\\n:no_bell: **Ignore**: Close this PR and you won't be reminded about this update again.\\n\\n---\\n\\n - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box\\n\\n---\\n\\nThis PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).",
|
||||
"prTitle": "Update dependency dummy to v1.1.0",
|
||||
|
|
@ -114,7 +111,6 @@ Array [
|
|||
"platformOptions": Object {
|
||||
"azureAutoComplete": false,
|
||||
"gitLabAutomerge": false,
|
||||
"statusCheckVerify": false,
|
||||
},
|
||||
"prBody": "This PR contains the following updates:\\n\\n| Package | Type | Update | Change |\\n|---|---|---|---|\\n| [dummy](https://dummy.com) ([source](https://github.com/renovateapp/dummy), [changelog](https://github.com/renovateapp/dummy/changelog.md)) | devDependencies | lockFileMaintenance | \`1.0.0\` -> \`1.1.0\` |\\n| a | | | \`zzzzzz\` -> \`aaaaaaa\` |\\n| b | | pin | \`some_old_value\` -> \`some_new_value\` |\\n| c | | | \`\` -> \`\` |\\n| d | | lockFileMaintenance | \`\` -> \`\` |\\n\\nnote 1\\n\\nnote 2\\n\\n:warning: Release Notes retrieval for this PR were skipped because no github.com credentials were available.\\nIf you are using the hosted GitLab app, please follow [this guide](https://docs.renovatebot.com/install-gitlab-app/#configuring-a-token-for-githubcom-hosted-release-notes). If you are self-hosted, please see [this instruction](https://github.com/renovatebot/renovate/blob/master/docs/usage/self-hosting.md#githubcom-token-for-release-notes) instead.\\n\\n:abcd: If you wish to disable git hash updates, add \`\\":disableDigestUpdates\\"\` to the extends array in your config.\\n\\n:wrench: This Pull Request updates lock files to use the latest dependency versions.\\n\\n---\\n\\n### Release Notes\\n\\n<details>\\n<summary>renovateapp/dummy</summary>\\n\\n### [\`v1.1.0\`](https://github.com/renovateapp/dummy/compare/v1.0.0...v1.1.0)\\n\\n[Compare Source](https://github.com/renovateapp/dummy/compare/v1.0.0...v1.1.0)\\n\\n</details>\\n\\n<details>\\n<summary>renovateapp/dummy</summary>\\n\\n</details>\\n\\n---\\n\\n### Renovate configuration\\n\\n:date: **Schedule**: At any time (no schedule defined).\\n\\n:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.\\n\\n:recycle: **Rebasing**: Never, or you tick the rebase/retry checkbox.\\n\\n:ghost: **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/config-help/issues) if that's undesired.\\n\\n---\\n\\n - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box\\n\\n---\\n\\nThis PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).",
|
||||
"prTitle": "Update dependency dummy to v1.1.0",
|
||||
|
|
@ -132,7 +128,6 @@ Array [
|
|||
"platformOptions": Object {
|
||||
"azureAutoComplete": false,
|
||||
"gitLabAutomerge": false,
|
||||
"statusCheckVerify": false,
|
||||
},
|
||||
"prBody": "This PR contains the following updates:\\n\\n| Package | Type | Update | Change |\\n|---|---|---|---|\\n| [dummy](https://dummy.com) ([source](https://github.com/renovateapp/dummy), [changelog](https://github.com/renovateapp/dummy/changelog.md)) | devDependencies | minor | \`1.0.0\` -> \`1.1.0\` |\\n\\n---\\n\\n### Release Notes\\n\\n<details>\\n<summary>someproject</summary>\\n\\n### [\`v1.1.0\`](https://github.com/renovateapp/dummy/compare/v1.0.0...v1.1.0)\\n\\n[Compare Source](https://github.com/renovateapp/dummy/compare/v1.0.0...v1.1.0)\\n\\n</details>\\n\\n---\\n\\n### Renovate configuration\\n\\n:date: **Schedule**: At any time (no schedule defined).\\n\\n:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.\\n\\n:recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.\\n\\n:no_bell: **Ignore**: Close this PR and you won't be reminded about this update again.\\n\\n---\\n\\n - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box\\n\\n---\\n\\nThis PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).",
|
||||
"prTitle": "Update dependency dummy to v1.1.0",
|
||||
|
|
|
|||
|
|
@ -354,7 +354,6 @@ export async function ensurePr(
|
|||
} else {
|
||||
const platformOptions: PlatformPrOptions = {
|
||||
azureAutoComplete: config.azureAutoComplete,
|
||||
statusCheckVerify: config.statusCheckVerify,
|
||||
gitLabAutomerge:
|
||||
config.automerge &&
|
||||
config.automergeType === 'pr' &&
|
||||
|
|
|
|||
Loading…
Reference in a new issue