refactor(datasource): Fix lint warnings (#7115)

lib/datasource/common.ts

@@ -28,7 +28,7 @@ export interface GetPkgReleasesConfig extends ReleasesConfigBase {
 }
 
 export function isGetPkgReleasesConfig(
-  input: any
+  input: unknown
 ): input is GetPkgReleasesConfig {
   return (
     (input as GetPkgReleasesConfig).datasource !== undefined &&
@@ -75,7 +75,7 @@ export interface DatasourceApi {
   getReleases(config: GetReleasesConfig): Promise<ReleaseResult | null>;
   defaultRegistryUrls?: string[];
   appendRegistryUrls?: string[];
-  defaultConfig?: object;
+  defaultConfig?: Record<string, unknown>;
   registryStrategy?: 'first' | 'hunt' | 'merge';
 }
 

lib/datasource/docker/index.spec.ts

@@ -230,7 +230,7 @@ describe(getName(__filename), () => {
       AWSMock.mock(
         'ECR',
         'getAuthorizationToken',
-        (params: {}, callback: Function) => {
+        (params: unknown, callback: (...unknown) => void) => {
           callback(null, {
             authorizationData: [{ authorizationToken: 'abcdef' }],
           });
@@ -262,7 +262,7 @@ describe(getName(__filename), () => {
       AWSMock.mock(
         'ECR',
         'getAuthorizationToken',
-        (params: {}, callback: Function) => {
+        (params: unknown, callback: (...unknown) => void) => {
           callback(null, {});
         }
       );
@@ -291,7 +291,7 @@ describe(getName(__filename), () => {
       AWSMock.mock(
         'ECR',
         'getAuthorizationToken',
-        (params: {}, callback: Function) => {
+        (params: unknown, callback: (...unknown) => void) => {
           callback(Error('some error'), null);
         }
       );

lib/datasource/docker/index.ts

@@ -175,7 +175,7 @@ async function getAuthHeaders(
     }
 
     // prettier-ignore
-    const authUrl = `${authenticateHeader.parms.realm}?service=${authenticateHeader.parms.service}&scope=repository:${repository}:pull`;
+    const authUrl = `${String(authenticateHeader.parms.realm)}?service=${String(authenticateHeader.parms.service)}&scope=repository:${repository}:pull`;
     logger.trace(
       `Obtaining docker registry token for ${repository} using url ${authUrl}`
     );
@@ -497,7 +497,7 @@ async function getLabels(
       return {};
     }
     let labels: Record<string, string> = {};
-    const configDigest = manifest.config.digest;
+    const configDigest: string = manifest.config.digest;
     const headers = await getAuthHeaders(registry, repository);
     // istanbul ignore if: Should never be happen
     if (!headers) {

lib/datasource/galaxy/index.ts

@@ -71,12 +71,9 @@ export async function getReleases({
     };
 
     result.dependencyUrl = galaxyProjectUrl;
-    if (resultObject.github_user && resultObject.github_repo) {
+    const { github_user: user = null, github_repo: repo = null } = resultObject;
-      result.sourceUrl =
+    if (typeof user === 'string' && typeof repo === 'string') {
-        'https://github.com/' +
+      result.sourceUrl = `https://github.com/${user}/${repo}`;
-        resultObject.github_user +
-        '/' +
-        resultObject.github_repo;
     }
 
     result.releases = versions.map(

lib/datasource/index.ts

@@ -214,11 +214,10 @@ async function fetchReleases(
 function getRawReleases(
   config: GetReleasesInternalConfig
 ): Promise<ReleaseResult | null> {
-  const cacheKey =
+  const { datasource, lookupName, registryUrls } = config;
-    cacheNamespace +
+  const cacheKey = `${cacheNamespace}${datasource}${lookupName}${String(
-    config.datasource +
+    registryUrls
-    config.lookupName +
+  )}`;
-    config.registryUrls;
   // By returning a Promise and reusing it, we should only fetch each package at most once
   const cachedResult = memCache.get(cacheKey);
   // istanbul ignore if
@@ -291,7 +290,9 @@ export function getDigest(
   );
 }
 
-export function getDefaultConfig(datasource: string): Promise<object> {
+export function getDefaultConfig(
+  datasource: string
+): Promise<Record<string, unknown>> {
   const loadedDatasource = load(datasource);
-  return Promise.resolve(loadedDatasource?.defaultConfig || {});
+  return Promise.resolve(loadedDatasource?.defaultConfig || Object.create({}));
 }

lib/datasource/npm/get.ts

@@ -45,6 +45,29 @@ export interface NpmDependency extends ReleaseResult {
   sourceDirectory?: string;
 }
 
+interface NpmResponse {
+  _id: string;
+  name?: string;
+  versions?: Record<
+    string,
+    {
+      repository?: {
+        url: string;
+        directory: string;
+      };
+      homepage?: string;
+      deprecated?: boolean;
+      gitHead?: string;
+    }
+  >;
+  repository?: {
+    url?: string;
+    directory?: string;
+  };
+  homepage?: string;
+  time?: Record<string, string>;
+}
+
 export async function getDependency(
   packageName: string,
   retries = 3
@@ -135,8 +158,7 @@ export async function getDependency(
       headers,
       useCache,
     };
-    // TODO: fix type
+    const raw = await http.getJson<NpmResponse>(pkgUrl, opts);
-    const raw = await http.getJson<any>(pkgUrl, opts);
     if (retries < 3) {
       logger.debug({ pkgUrl, retries }, 'Recovered from npm error');
     }

lib/datasource/npm/npmrc.ts

@@ -39,7 +39,7 @@ function sanitize(key: string, val: string): void {
     add(val);
     const password = Buffer.from(val, 'base64').toString();
     add(password);
-    const username = npmrc[key.replace(':_password', ':username')];
+    const username: string = npmrc[key.replace(':_password', ':username')];
     add(Buffer.from(`${username}:${password}`).toString('base64'));
   }
 }

lib/datasource/nuget/v3.ts

@@ -133,7 +133,7 @@ export async function getReleases(
   ).flat();
 
   let homepage = null;
-  let latestStable = null;
+  let latestStable: string = null;
   const releases = catalogEntries.map(
     ({ version, published: releaseTimestamp, projectUrl }) => {
       const release: Release = { version };

lib/datasource/pypi/index.ts

@@ -14,7 +14,7 @@ export const defaultRegistryUrls = [
 ];
 export const registryStrategy = 'merge';
 
-const github_repo_pattern = /^https?:\/\/github\.com\/[^\\/]+\/[^\\/]+$/;
+const githubRepoPattern = /^https?:\/\/github\.com\/[^\\/]+\/[^\\/]+$/;
 const http = new Http(id);
 
 type PypiJSONRelease = {
@@ -82,7 +82,7 @@ async function getDependency(
 
   if (dep.info?.home_page) {
     dependency.homepage = dep.info.home_page;
-    if (github_repo_pattern.exec(dep.info.home_page)) {
+    if (githubRepoPattern.exec(dep.info.home_page)) {
       dependency.sourceUrl = dep.info.home_page.replace('http://', 'https://');
     }
   }
@@ -96,7 +96,7 @@ async function getDependency(
         (lower.startsWith('repo') ||
           lower === 'code' ||
           lower === 'source' ||
-          github_repo_pattern.exec(projectUrl))
+          githubRepoPattern.exec(projectUrl))
       ) {
         dependency.sourceUrl = projectUrl;
       }

lib/datasource/repology/index.spec.ts

@@ -8,13 +8,13 @@ import { RepologyPackage, id as datasource } from '.';
 
 const repologyApiHost = 'https://repology.org/';
 
-type mockResponse = { status: number; body?: string };
+type ResponseMock = { status: number; body?: string };
 
 const mockProjectBy = (
   repo: string,
   name: string,
-  binary: mockResponse,
+  binary: ResponseMock,
-  source: mockResponse
+  source: ResponseMock
 ) => {
   const endpoint = '/tools/project-by';
   const defaultParams = {

lib/datasource/rubygems/get-rubygems-org.ts

@@ -94,15 +94,15 @@ function isDataStale(): boolean {
   return minutesElapsed >= 5;
 }
 
-let _updateRubyGemsVersions: Promise<void> | undefined;
+let updateRubyGemsVersionsPromise: Promise<void> | undefined;
 
 async function syncVersions(): Promise<void> {
   if (isDataStale()) {
-    _updateRubyGemsVersions =
+    updateRubyGemsVersionsPromise =
       // eslint-disable-next-line @typescript-eslint/no-misused-promises
-      _updateRubyGemsVersions || updateRubyGemsVersions();
+      updateRubyGemsVersionsPromise || updateRubyGemsVersions();
-    await _updateRubyGemsVersions;
+    await updateRubyGemsVersionsPromise;
-    _updateRubyGemsVersions = null;
+    updateRubyGemsVersionsPromise = null;
   }
 }