renovate/renovate
1
0
Fork 0
mirror of https://github.com/renovatebot/renovate.git synced 2025-01-12 06:56:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

fix: pinning digest of latest version (#2359)

Browse source 
If the dependency already is the latest version, filteredVersions is
empty here, and then the early exit skips over the pinning code
This commit is contained in:
Maximilian Gaß 2018-08-11 10:03:57 +02:00 committed by Rhys Arkins
parent eb167f571c
commit 15ee7ab4ae
3 changed files with 39 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
lib/workers/repository/process/lookup/index.js
View file

@ -108,9 +108,6 @@ async function lookupUpdates(config) {
allVersions,
releases
);
if (!filteredVersions.length) {
return res;
}
const buckets = {};
for (const toVersion of filteredVersions) {
const update = { fromVersion, toVersion };

20
test/workers/repository/process/lookup/__snapshots__/index.spec.js.snap
View file

@ -127,6 +127,26 @@ Object {
}
`;
exports[`manager/npm/lookup .lookupUpdates() handles digest pin for up to date version 1`] = `
Object {
"releases": Array [
Object {
"version": "8.1.0",
},
],
"repositoryUrl": null,
"updates": Array [
Object {
"newDigest": "sha256:aaaaaaaaaaaaaaaa",
"newDigestShort": "aaaaaa",
"newValue": "8.1.0",
"updateType": "pin",
},
],
"warnings": Array [],
}
`;
exports[`manager/npm/lookup .lookupUpdates() handles digest update 1`] = `
Object {
"releases": Array [

19
test/workers/repository/process/lookup/index.spec.js
View file

@ -919,6 +919,25 @@ describe('manager/npm/lookup', () => {
const res = await lookup.lookupUpdates(config);
expect(res).toMatchSnapshot();
});
it('handles digest pin for up to date version', async () => {
config.currentValue = '8.1.0';
config.depName = 'node';
config.purl = 'pkg:docker/node';
config.pinDigests = true;
docker.getPkgReleases.mockReturnValueOnce({
releases: [
{
version: '8.0.0',
},
{
version: '8.1.0',
},
],
});
docker.getDigest.mockReturnValueOnce('sha256:aaaaaaaaaaaaaaaa');
const res = await lookup.lookupUpdates(config);
expect(res).toMatchSnapshot();
});
it('handles digest pin for non-version', async () => {
config.currentValue = 'alpine';
config.depName = 'node';