renovate/renovate
1
0
Fork 0
mirror of https://github.com/renovatebot/renovate.git synced 2025-01-11 14:36:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

refactor: move config globals inside functions (#1088)

Browse source 
This was necessary when attempting to use jest mock all
This commit is contained in:
Rhys Arkins 2017-11-03 07:43:26 +01:00 committed by GitHub
parent 9dd3fd968c
commit 1e5a5cab79
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 25 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
lib/config/massage.js
View file

@ -1,12 +1,7 @@
const deepcopy = require('deepcopy');
const options = require('./definitions').getOptions();
const allowedStrings = [];
options.forEach(option => {
if (option.allowString) {
allowedStrings.push(option.name);
}
});
let allowedStrings;
module.exports = {
massageConfig,
@ -14,6 +9,14 @@ module.exports = {
// Returns a massaged config
function massageConfig(config) {
if (!allowedStrings) {
allowedStrings = [];
options.forEach(option => {
if (option.allowString) {
allowedStrings.push(option.name);
}
});
}
const massagedConfig = deepcopy(config);
for (const key of Object.keys(config)) {
const val = config[key];

11
lib/config/migration.js
View file

@ -2,10 +2,7 @@ const later = require('later');
const deepcopy = require('deepcopy');
const options = require('./definitions').getOptions();
const optionTypes = {};
options.forEach(option => {
optionTypes[option.name] = option.type;
});
let optionTypes;
module.exports = {
migrateConfig,
@ -27,6 +24,12 @@ const removedOptions = [
// Returns a migrated config
function migrateConfig(config) {
if (!optionTypes) {
optionTypes = {};
options.forEach(option => {
optionTypes[option.name] = option.type;
});
}
let isMigrated = false;
const migratedConfig = deepcopy(config);
for (const key of Object.keys(config)) {

3
lib/config/presets.js
View file

@ -161,7 +161,8 @@ async function getPreset(preset, logger) {
logger.warn(`Cannot find preset ${preset}`);
return {};
}
logger.debug({ presetConfig }, `Found preset ${preset}`);
logger.debug(`Found preset ${preset}`);
logger.trace({ presetConfig });
if (params) {
const argMapping = {};
for (const [index, value] of params.entries()) {

11
lib/config/validation.js
View file

@ -1,16 +1,19 @@
const options = require('./definitions').getOptions();
const { hasValidSchedule } = require('../workers/branch/schedule');
const optionTypes = {};
options.forEach(option => {
optionTypes[option.name] = option.type;
});
let optionTypes;
module.exports = {
validateConfig,
};
function validateConfig(config) {
if (!optionTypes) {
optionTypes = {};
options.forEach(option => {
optionTypes[option.name] = option.type;
});
}
let errors = [];
let warnings = [];