renovate/renovate
1
0
Fork 0
mirror of https://github.com/renovatebot/renovate.git synced 2025-01-13 07:26:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

refactor: move nested function to module scope (#17361)

Browse source 
Co-authored-by: Rhys Arkins <rhys@arkins.net>
This commit is contained in:
Michael Kriese 2022-08-23 21:38:24 +02:00 committed by GitHub
parent 57ade2b33e
commit 33e3bf7ce2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 23 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
lib/modules/manager/regex/utils.ts
View file

@ -20,15 +20,11 @@ export const validMatchFields = [
type ValidMatchFields = typeof validMatchFields[number];
export function createDependency(
extractionTemplate: ExtractionTemplate,
config: CustomExtractConfig,
dep?: PackageDependency
): PackageDependency | null {
const dependency = dep ?? {};
const { groups, replaceString } = extractionTemplate;
function updateDependency(field: ValidMatchFields, value: string): void {
function updateDependency(
dependency: PackageDependency,
field: ValidMatchFields,
value: string
): void {
switch (field) {
case 'registryUrl':
// check if URL is valid and pack inside an array
@ -43,7 +39,15 @@ export function createDependency(
dependency[field] = value;
break;
}
}
}
export function createDependency(
extractionTemplate: ExtractionTemplate,
config: CustomExtractConfig,
dep?: PackageDependency
): PackageDependency | null {
const dependency = dep ?? {};
const { groups, replaceString } = extractionTemplate;
for (const field of validMatchFields) {
const fieldTemplate = `${field}Template` as keyof RegexManagerTemplates;
@ -51,7 +55,7 @@ export function createDependency(
if (tmpl) {
try {
const compiled = template.compile(tmpl, groups, false);
updateDependency(field, compiled);
updateDependency(dependency, field, compiled);
} catch (err) {
logger.warn(
{ template: tmpl },
@ -60,7 +64,7 @@ export function createDependency(
return null;
}
} else if (groups[field]) {
updateDependency(field, groups[field]);
updateDependency(dependency, field, groups[field]);
}
}
dependency.replaceString = replaceString;