renovate/renovate
1
0
Fork 0
mirror of https://github.com/renovatebot/renovate.git synced 2025-01-13 15:36:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

fix(gitlab): fetch all open issues (#6597)

Browse source
This commit is contained in:
Rhys Arkins 2020-06-27 09:55:02 +02:00 committed by GitHub
parent 80fe38e68c
commit 49447989e1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 31 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
lib/platform/gitlab/__snapshots__/index.spec.ts.snap
View file

@ -714,7 +714,7 @@ Array [
"user-agent": "https://github.com/renovatebot/renovate", "user-agent": "https://github.com/renovatebot/renovate",
}, },
"method": "GET", "method": "GET",
"url": "https://gitlab.com/api/v4/projects/undefined/issues?state=opened", "url": "https://gitlab.com/api/v4/projects/undefined/issues?per_page=100&author_id=undefined&state=opened",
}, },
Object { Object {
"body": "{\\"title\\":\\"new-title\\",\\"description\\":\\"new-content\\"}", "body": "{\\"title\\":\\"new-title\\",\\"description\\":\\"new-content\\"}",
@ -744,7 +744,7 @@ Array [
"user-agent": "https://github.com/renovatebot/renovate", "user-agent": "https://github.com/renovatebot/renovate",
}, },
"method": "GET", "method": "GET",
"url": "https://gitlab.com/api/v4/projects/undefined/issues?state=opened", "url": "https://gitlab.com/api/v4/projects/undefined/issues?per_page=100&author_id=undefined&state=opened",
}, },
Object { Object {
"headers": Object { "headers": Object {
@ -771,7 +771,7 @@ Array [
"user-agent": "https://github.com/renovatebot/renovate", "user-agent": "https://github.com/renovatebot/renovate",
}, },
"method": "GET", "method": "GET",
"url": "https://gitlab.com/api/v4/projects/undefined/issues?state=opened", "url": "https://gitlab.com/api/v4/projects/undefined/issues?per_page=100&author_id=undefined&state=opened",
}, },
Object { Object {
"headers": Object { "headers": Object {
@ -812,7 +812,7 @@ Array [
"user-agent": "https://github.com/renovatebot/renovate", "user-agent": "https://github.com/renovatebot/renovate",
}, },
"method": "GET", "method": "GET",
"url": "https://gitlab.com/api/v4/projects/undefined/issues?state=opened", "url": "https://gitlab.com/api/v4/projects/undefined/issues?per_page=100&author_id=undefined&state=opened",
}, },
Object { Object {
"body": "{\\"state_event\\":\\"close\\"}", "body": "{\\"state_event\\":\\"close\\"}",
@ -842,7 +842,7 @@ Array [
"user-agent": "https://github.com/renovatebot/renovate", "user-agent": "https://github.com/renovatebot/renovate",
}, },
"method": "GET", "method": "GET",
"url": "https://gitlab.com/api/v4/projects/undefined/issues?state=opened", "url": "https://gitlab.com/api/v4/projects/undefined/issues?per_page=100&author_id=undefined&state=opened",
}, },
Object { Object {
"headers": Object { "headers": Object {
@ -869,7 +869,7 @@ Array [
"user-agent": "https://github.com/renovatebot/renovate", "user-agent": "https://github.com/renovatebot/renovate",
}, },
"method": "GET", "method": "GET",
"url": "https://gitlab.com/api/v4/projects/undefined/issues?state=opened", "url": "https://gitlab.com/api/v4/projects/undefined/issues?per_page=100&author_id=undefined&state=opened",
}, },
] ]
`; `;

24
lib/platform/gitlab/index.spec.ts
View file

@ -712,7 +712,9 @@ describe('platform/gitlab', () => {
it('returns null if no issue', async () => { it('returns null if no issue', async () => {
httpMock httpMock
.scope(gitlabApiHost) .scope(gitlabApiHost)
.get('/api/v4/projects/undefined/issues?state=opened') .get(
'/api/v4/projects/undefined/issues?per_page=100&author_id=undefined&state=opened'
)
.reply(200, [ .reply(200, [
{ {
iid: 1, iid: 1,
@ -730,7 +732,9 @@ describe('platform/gitlab', () => {
it('finds issue', async () => { it('finds issue', async () => {
httpMock httpMock
.scope(gitlabApiHost) .scope(gitlabApiHost)
.get('/api/v4/projects/undefined/issues?state=opened') .get(
'/api/v4/projects/undefined/issues?per_page=100&author_id=undefined&state=opened'
)
.reply(200, [ .reply(200, [
{ {
iid: 1, iid: 1,
@ -752,7 +756,9 @@ describe('platform/gitlab', () => {
it('creates issue', async () => { it('creates issue', async () => {
httpMock httpMock
.scope(gitlabApiHost) .scope(gitlabApiHost)
.get('/api/v4/projects/undefined/issues?state=opened') .get(
'/api/v4/projects/undefined/issues?per_page=100&author_id=undefined&state=opened'
)
.reply(200, [ .reply(200, [
{ {
iid: 1, iid: 1,
@ -775,7 +781,9 @@ describe('platform/gitlab', () => {
it('updates issue', async () => { it('updates issue', async () => {
httpMock httpMock
.scope(gitlabApiHost) .scope(gitlabApiHost)
.get('/api/v4/projects/undefined/issues?state=opened') .get(
'/api/v4/projects/undefined/issues?per_page=100&author_id=undefined&state=opened'
)
.reply(200, [ .reply(200, [
{ {
iid: 1, iid: 1,
@ -800,7 +808,9 @@ describe('platform/gitlab', () => {
it('skips update if unchanged', async () => { it('skips update if unchanged', async () => {
httpMock httpMock
.scope(gitlabApiHost) .scope(gitlabApiHost)
.get('/api/v4/projects/undefined/issues?state=opened') .get(
'/api/v4/projects/undefined/issues?per_page=100&author_id=undefined&state=opened'
)
.reply(200, [ .reply(200, [
{ {
iid: 1, iid: 1,
@ -825,7 +835,9 @@ describe('platform/gitlab', () => {
it('closes issue', async () => { it('closes issue', async () => {
httpMock httpMock
.scope(gitlabApiHost) .scope(gitlabApiHost)
.get('/api/v4/projects/undefined/issues?state=opened') .get(
'/api/v4/projects/undefined/issues?per_page=100&author_id=undefined&state=opened'
)
.reply(200, [ .reply(200, [
{ {
iid: 1, iid: 1,

8
lib/platform/gitlab/index.ts
View file

@ -742,10 +742,16 @@ export async function setBranchStatus({
export async function getIssueList(): Promise<any[]> { export async function getIssueList(): Promise<any[]> {
if (!config.issueList) { if (!config.issueList) {
const query = new URLSearchParams({
per_page: '100',
author_id: `${authorId}`,
state: 'opened',
}).toString();
const res = await gitlabApi.getJson<{ iid: number; title: string }[]>( const res = await gitlabApi.getJson<{ iid: number; title: string }[]>(
`projects/${config.repository}/issues?state=opened`, `projects/${config.repository}/issues?${query}`,
{ {
useCache: false, useCache: false,
paginate: true,
} }
); );
// istanbul ignore if // istanbul ignore if