From 5d025236d46710298680af0d7c4394c4a2e0d78a Mon Sep 17 00:00:00 2001 From: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com> Date: Wed, 28 Oct 2020 16:51:34 +0100 Subject: [PATCH] docs: ask contributors to not force-push their branches (#7590) --- .github/contributing.md | 6 ++++++ .github/pull_request_template.md | 3 +++ 2 files changed, 9 insertions(+) diff --git a/.github/contributing.md b/.github/contributing.md index f71b4349c7..1e283e6ed2 100644 --- a/.github/contributing.md +++ b/.github/contributing.md @@ -23,6 +23,12 @@ afterwards. Also, let the maintainers know that you plan to work on a particular Pull Requests can only be merged once all status checks are green, which means `yarn test` passes, and coverage is 100%. +## Do not force push to your pull request branch + +Please do not force push to your PR's branch after you have created your PR, as doing so makes it harder for us to review your work. +PRs will always be squashed by us when we merge your work. +Commit as many times as you need in your pull request branch. + ## Slack collaboration with maintainers Sometimes the codebase can be a challenge to navigate, especially for a first-time contributor. We don't want you spending an hour trying to work out something that would take us only a minute to explain. diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 97f35a4bfd..e305e4bd10 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -24,3 +24,6 @@ I have verified these changes via: - [ ] Unit tests + ran on a real repository + + +