renovate/renovate
1
0
Fork 0
mirror of https://github.com/renovatebot/renovate.git synced 2025-01-12 06:56:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

fix: increase prNotPendingHours default to 24 hours (#1316)

Browse source 
To prevent PRs being opened prior to the `unpublishSafe` check having
transitioned from `pending` to `success`, when using `not-pending`
mode.

Fixes #1312.
This commit is contained in:
Ed Morley 2017-12-20 05:47:20 +00:00 committed by Rhys Arkins
parent 2c6a2dd43b
commit 709a68c7ae
5 changed files with 16 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
docs/configuration.md
View file

@ -609,7 +609,7 @@ location with this method.
<td>`prNotPendingHours`</td> <td>`prNotPendingHours`</td>
<td>Timeout in hours for when prCreation=not-pending</td> <td>Timeout in hours for when prCreation=not-pending</td>
<td>integer</td> <td>integer</td>
<td><pre>12</pre></td> <td><pre>24</pre></td>
<td>`RENOVATE_PR_NOT_PENDING_HOURS`</td> <td>`RENOVATE_PR_NOT_PENDING_HOURS`</td>
<td>`--pr-not-pending-hours`<td> <td>`--pr-not-pending-hours`<td>
</tr> </tr>

3
lib/config/definitions.js
View file

@ -495,7 +495,8 @@ const options = [
name: 'prNotPendingHours', name: 'prNotPendingHours',
description: 'Timeout in hours for when prCreation=not-pending', description: 'Timeout in hours for when prCreation=not-pending',
type: 'integer', type: 'integer',
default: 12, // Must be at least 24 hours to give time for the unpublishSafe check to "complete".
default: 24,
}, },
// Automatic merging // Automatic merging
{ {

14
test/manager/__snapshots__/resolve.spec.js.snap
View file

@ -502,7 +502,7 @@ Please make sure the following warnings are safe to ignore:
This PR has been generated by [Renovate Bot](https://renovateapp.com).", This PR has been generated by [Renovate Bot](https://renovateapp.com).",
"prCreation": "immediate", "prCreation": "immediate",
"prNotPendingHours": 12, "prNotPendingHours": 24,
"prTitle": "{{#if isPin}}Pin{{else}}{{#if isRollback}}Roll back{{else}}Update{{/if}}{{/if}} dependency {{depName}} to {{#if isRange}}{{newVersion}}{{else}}{{#if isMajor}}v{{newVersionMajor}}{{else}}v{{newVersion}}{{/if}}{{/if}}", "prTitle": "{{#if isPin}}Pin{{else}}{{#if isRollback}}Roll back{{else}}Update{{/if}}{{/if}} dependency {{depName}} to {{#if isRange}}{{newVersion}}{{else}}{{#if isMajor}}v{{newVersionMajor}}{{else}}v{{newVersion}}{{/if}}{{/if}}",
"privateKey": null, "privateKey": null,
"rebaseStalePrs": false, "rebaseStalePrs": false,
@ -1040,7 +1040,7 @@ Please make sure the following warnings are safe to ignore:
This PR has been generated by [Renovate Bot](https://renovateapp.com).", This PR has been generated by [Renovate Bot](https://renovateapp.com).",
"prCreation": "immediate", "prCreation": "immediate",
"prNotPendingHours": 12, "prNotPendingHours": 24,
"prTitle": "{{#if isPin}}Pin{{else}}{{#if isRollback}}Roll back{{else}}Update{{/if}}{{/if}} dependency {{depName}} to {{#if isRange}}{{newVersion}}{{else}}{{#if isMajor}}v{{newVersionMajor}}{{else}}v{{newVersion}}{{/if}}{{/if}}", "prTitle": "{{#if isPin}}Pin{{else}}{{#if isRollback}}Roll back{{else}}Update{{/if}}{{/if}} dependency {{depName}} to {{#if isRange}}{{newVersion}}{{else}}{{#if isMajor}}v{{newVersionMajor}}{{else}}v{{newVersion}}{{/if}}{{/if}}",
"privateKey": null, "privateKey": null,
"rebaseStalePrs": false, "rebaseStalePrs": false,
@ -1834,7 +1834,7 @@ Please make sure the following warnings are safe to ignore:
This PR has been generated by [Renovate Bot](https://renovateapp.com).", This PR has been generated by [Renovate Bot](https://renovateapp.com).",
"prCreation": "immediate", "prCreation": "immediate",
"prNotPendingHours": 12, "prNotPendingHours": 24,
"prTitle": "{{#if isPin}}Pin{{else}}{{#if isRollback}}Roll back{{else}}Update{{/if}}{{/if}} dependency {{depName}} to {{#if isRange}}{{newVersion}}{{else}}{{#if isMajor}}v{{newVersionMajor}}{{else}}v{{newVersion}}{{/if}}{{/if}}", "prTitle": "{{#if isPin}}Pin{{else}}{{#if isRollback}}Roll back{{else}}Update{{/if}}{{/if}} dependency {{depName}} to {{#if isRange}}{{newVersion}}{{else}}{{#if isMajor}}v{{newVersionMajor}}{{else}}v{{newVersion}}{{/if}}{{/if}}",
"privateKey": null, "privateKey": null,
"rebaseStalePrs": false, "rebaseStalePrs": false,
@ -2367,7 +2367,7 @@ Please make sure the following warnings are safe to ignore:
This PR has been generated by [Renovate Bot](https://renovateapp.com).", This PR has been generated by [Renovate Bot](https://renovateapp.com).",
"prCreation": "immediate", "prCreation": "immediate",
"prNotPendingHours": 12, "prNotPendingHours": 24,
"prTitle": "{{#if isPin}}Pin{{else}}{{#if isRollback}}Roll back{{else}}Update{{/if}}{{/if}} dependency {{depName}} to {{#if isRange}}{{newVersion}}{{else}}{{#if isMajor}}v{{newVersionMajor}}{{else}}v{{newVersion}}{{/if}}{{/if}}", "prTitle": "{{#if isPin}}Pin{{else}}{{#if isRollback}}Roll back{{else}}Update{{/if}}{{/if}} dependency {{depName}} to {{#if isRange}}{{newVersion}}{{else}}{{#if isMajor}}v{{newVersionMajor}}{{else}}v{{newVersion}}{{/if}}{{/if}}",
"privateKey": null, "privateKey": null,
"rebaseStalePrs": false, "rebaseStalePrs": false,
@ -2891,7 +2891,7 @@ Please make sure the following warnings are safe to ignore:
This PR has been generated by [Renovate Bot](https://renovateapp.com).", This PR has been generated by [Renovate Bot](https://renovateapp.com).",
"prCreation": "immediate", "prCreation": "immediate",
"prNotPendingHours": 12, "prNotPendingHours": 24,
"prTitle": "{{#if isPin}}Pin{{else}}{{#if isRollback}}Roll back{{else}}Update{{/if}}{{/if}} dependency {{depName}} to {{#if isRange}}{{newVersion}}{{else}}{{#if isMajor}}v{{newVersionMajor}}{{else}}v{{newVersion}}{{/if}}{{/if}}", "prTitle": "{{#if isPin}}Pin{{else}}{{#if isRollback}}Roll back{{else}}Update{{/if}}{{/if}} dependency {{depName}} to {{#if isRange}}{{newVersion}}{{else}}{{#if isMajor}}v{{newVersionMajor}}{{else}}v{{newVersion}}{{/if}}{{/if}}",
"privateKey": null, "privateKey": null,
"rebaseStalePrs": false, "rebaseStalePrs": false,
@ -3415,7 +3415,7 @@ Please make sure the following warnings are safe to ignore:
This PR has been generated by [Renovate Bot](https://renovateapp.com).", This PR has been generated by [Renovate Bot](https://renovateapp.com).",
"prCreation": "immediate", "prCreation": "immediate",
"prNotPendingHours": 12, "prNotPendingHours": 24,
"prTitle": "{{#if isPin}}Pin{{else}}{{#if isRollback}}Roll back{{else}}Update{{/if}}{{/if}} dependency {{depName}} to {{#if isRange}}{{newVersion}}{{else}}{{#if isMajor}}v{{newVersionMajor}}{{else}}v{{newVersion}}{{/if}}{{/if}}", "prTitle": "{{#if isPin}}Pin{{else}}{{#if isRollback}}Roll back{{else}}Update{{/if}}{{/if}} dependency {{depName}} to {{#if isRange}}{{newVersion}}{{else}}{{#if isMajor}}v{{newVersionMajor}}{{else}}v{{newVersion}}{{/if}}{{/if}}",
"privateKey": null, "privateKey": null,
"rebaseStalePrs": false, "rebaseStalePrs": false,
@ -3948,7 +3948,7 @@ Please make sure the following warnings are safe to ignore:
This PR has been generated by [Renovate Bot](https://renovateapp.com).", This PR has been generated by [Renovate Bot](https://renovateapp.com).",
"prCreation": "immediate", "prCreation": "immediate",
"prNotPendingHours": 12, "prNotPendingHours": 24,
"prTitle": "{{#if isPin}}Pin{{else}}{{#if isRollback}}Roll back{{else}}Update{{/if}}{{/if}} dependency {{depName}} to {{#if isRange}}{{newVersion}}{{else}}{{#if isMajor}}v{{newVersionMajor}}{{else}}v{{newVersion}}{{/if}}{{/if}}", "prTitle": "{{#if isPin}}Pin{{else}}{{#if isRollback}}Roll back{{else}}Update{{/if}}{{/if}} dependency {{depName}} to {{#if isRange}}{{newVersion}}{{else}}{{#if isMajor}}v{{newVersionMajor}}{{else}}v{{newVersion}}{{/if}}{{/if}}",
"privateKey": null, "privateKey": null,
"rebaseStalePrs": false, "rebaseStalePrs": false,

2
test/workers/package/__snapshots__/index.spec.js.snap
View file

@ -139,7 +139,7 @@ Please make sure the following warnings are safe to ignore:
This PR has been generated by [Renovate Bot](https://renovateapp.com).", This PR has been generated by [Renovate Bot](https://renovateapp.com).",
"prCreation": "immediate", "prCreation": "immediate",
"prNotPendingHours": 12, "prNotPendingHours": 24,
"prTitle": "{{#if isPin}}Pin{{else}}{{#if isRollback}}Roll back{{else}}Update{{/if}}{{/if}} dependency {{depName}} to {{#if isRange}}{{newVersion}}{{else}}{{#if isMajor}}v{{newVersionMajor}}{{else}}v{{newVersion}}{{/if}}{{/if}}", "prTitle": "{{#if isPin}}Pin{{else}}{{#if isRollback}}Roll back{{else}}Update{{/if}}{{/if}} dependency {{depName}} to {{#if isRange}}{{newVersion}}{{else}}{{#if isMajor}}v{{newVersionMajor}}{{else}}v{{newVersion}}{{/if}}{{/if}}",
"rebaseStalePrs": true, "rebaseStalePrs": true,
"recreateClosed": true, "recreateClosed": true,

10
test/workers/repository/updates/__snapshots__/branchify.spec.js.snap
View file

@ -541,7 +541,7 @@ Please make sure the following warnings are safe to ignore:
This PR has been generated by [Renovate Bot](https://renovateapp.com).", This PR has been generated by [Renovate Bot](https://renovateapp.com).",
"prCreation": "immediate", "prCreation": "immediate",
"prNotPendingHours": 12, "prNotPendingHours": 24,
"prTitle": "{{#if isPin}}Pin{{else}}{{#if isRollback}}Roll back{{else}}Update{{/if}}{{/if}} dependency {{depName}} to {{#if isRange}}{{newVersion}}{{else}}{{#if isMajor}}v{{newVersionMajor}}{{else}}v{{newVersion}}{{/if}}{{/if}}", "prTitle": "{{#if isPin}}Pin{{else}}{{#if isRollback}}Roll back{{else}}Update{{/if}}{{/if}} dependency {{depName}} to {{#if isRange}}{{newVersion}}{{else}}{{#if isMajor}}v{{newVersionMajor}}{{else}}v{{newVersion}}{{/if}}{{/if}}",
"privateKey": null, "privateKey": null,
"rebaseStalePrs": false, "rebaseStalePrs": false,
@ -1102,7 +1102,7 @@ Please make sure the following warnings are safe to ignore:
This PR has been generated by [Renovate Bot](https://renovateapp.com).", This PR has been generated by [Renovate Bot](https://renovateapp.com).",
"prCreation": "immediate", "prCreation": "immediate",
"prNotPendingHours": 12, "prNotPendingHours": 24,
"prTitle": "{{#if isPin}}Pin{{else}}{{#if isRollback}}Roll back{{else}}Update{{/if}}{{/if}} dependency {{depName}} to {{#if isRange}}{{newVersion}}{{else}}{{#if isMajor}}v{{newVersionMajor}}{{else}}v{{newVersion}}{{/if}}{{/if}}", "prTitle": "{{#if isPin}}Pin{{else}}{{#if isRollback}}Roll back{{else}}Update{{/if}}{{/if}} dependency {{depName}} to {{#if isRange}}{{newVersion}}{{else}}{{#if isMajor}}v{{newVersionMajor}}{{else}}v{{newVersion}}{{/if}}{{/if}}",
"privateKey": null, "privateKey": null,
"rebaseStalePrs": false, "rebaseStalePrs": false,
@ -1669,7 +1669,7 @@ Please make sure the following warnings are safe to ignore:
This PR has been generated by [Renovate Bot](https://renovateapp.com).", This PR has been generated by [Renovate Bot](https://renovateapp.com).",
"prCreation": "immediate", "prCreation": "immediate",
"prNotPendingHours": 12, "prNotPendingHours": 24,
"prTitle": "{{#if isPin}}Pin{{else}}{{#if isRollback}}Roll back{{else}}Update{{/if}}{{/if}} dependency {{depName}} to {{#if isRange}}{{newVersion}}{{else}}{{#if isMajor}}v{{newVersionMajor}}{{else}}v{{newVersion}}{{/if}}{{/if}}", "prTitle": "{{#if isPin}}Pin{{else}}{{#if isRollback}}Roll back{{else}}Update{{/if}}{{/if}} dependency {{depName}} to {{#if isRange}}{{newVersion}}{{else}}{{#if isMajor}}v{{newVersionMajor}}{{else}}v{{newVersion}}{{/if}}{{/if}}",
"privateKey": null, "privateKey": null,
"rebaseStalePrs": false, "rebaseStalePrs": false,
@ -2224,7 +2224,7 @@ Please make sure the following warnings are safe to ignore:
This PR has been generated by [Renovate Bot](https://renovateapp.com).", This PR has been generated by [Renovate Bot](https://renovateapp.com).",
"prCreation": "immediate", "prCreation": "immediate",
"prNotPendingHours": 12, "prNotPendingHours": 24,
"prTitle": "{{#if isPin}}Pin{{else}}{{#if isRollback}}Roll back{{else}}Update{{/if}}{{/if}} dependency {{depName}} to {{#if isRange}}{{newVersion}}{{else}}{{#if isMajor}}v{{newVersionMajor}}{{else}}v{{newVersion}}{{/if}}{{/if}}", "prTitle": "{{#if isPin}}Pin{{else}}{{#if isRollback}}Roll back{{else}}Update{{/if}}{{/if}} dependency {{depName}} to {{#if isRange}}{{newVersion}}{{else}}{{#if isMajor}}v{{newVersionMajor}}{{else}}v{{newVersion}}{{/if}}{{/if}}",
"privateKey": null, "privateKey": null,
"rebaseStalePrs": false, "rebaseStalePrs": false,
@ -2774,7 +2774,7 @@ Please make sure the following warnings are safe to ignore:
This PR has been generated by [Renovate Bot](https://renovateapp.com).", This PR has been generated by [Renovate Bot](https://renovateapp.com).",
"prCreation": "immediate", "prCreation": "immediate",
"prNotPendingHours": 12, "prNotPendingHours": 24,
"prTitle": "{{#if isPin}}Pin{{else}}{{#if isRollback}}Roll back{{else}}Update{{/if}}{{/if}} dependency {{depName}} to {{#if isRange}}{{newVersion}}{{else}}{{#if isMajor}}v{{newVersionMajor}}{{else}}v{{newVersion}}{{/if}}{{/if}}", "prTitle": "{{#if isPin}}Pin{{else}}{{#if isRollback}}Roll back{{else}}Update{{/if}}{{/if}} dependency {{depName}} to {{#if isRange}}{{newVersion}}{{else}}{{#if isMajor}}v{{newVersionMajor}}{{else}}v{{newVersion}}{{/if}}{{/if}}",
"privateKey": null, "privateKey": null,
"rebaseStalePrs": false, "rebaseStalePrs": false,