renovate/renovate
1
0
Fork 0
mirror of https://github.com/renovatebot/renovate.git synced 2025-01-12 06:56:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

fix: check returned pypi name against requested name

Browse source
This commit is contained in:
Rhys Arkins 2018-07-05 11:25:48 +02:00
parent db38553d05
commit 9153e3905f
2 changed files with 19 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
lib/datasource/pypi.js
View file

@ -17,6 +17,13 @@ async function getDependency(purl) {
logger.debug({ depName }, 'pip package not found');
return null;
}
if (!(dep.info && dep.info.name === depName)) {
logger.warn(
{ lookupName: depName, returnedName: dep.name },
'Returned name does not match with requested name'
);
return null;
}
if (dep.info && dep.info.home_page) {
if (dep.info.home_page.startsWith('https://github.com')) {
dependency.repositoryUrl = dep.info.home_page;

12
test/datasource/pypi.spec.js
View file

@ -30,6 +30,7 @@ describe('datasource/pypi', () => {
got.mockReturnValueOnce({
body: {
info: {
name: 'something',
home_page: 'https://microsoft.com',
},
},
@ -38,5 +39,16 @@ describe('datasource/pypi', () => {
await datasource.getDependency('pkg:pypi/something')
).toMatchSnapshot();
});
it('returns null if mismatched name', async () => {
got.mockReturnValueOnce({
body: {
info: {
name: 'something-else',
home_page: 'https://microsoft.com',
},
},
});
expect(await datasource.getDependency('pkg:pypi/something')).toBeNull();
});
});
});