renovate/renovate
1
0
Fork 0
mirror of https://github.com/renovatebot/renovate.git synced 2025-01-12 06:56:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

refactor: sort versions and commits from oldest to newest

Browse source 
List versions and their commits in PR bodies in the order they were made (oldest to newest).
This commit is contained in:
Rhys Arkins 2018-02-02 05:42:22 +01:00
parent 8b1a8144a1
commit 9195adc58a
3 changed files with 141 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
lib/workers/pr/changelog.js
View file

@ -31,6 +31,16 @@ async function getChangeLogJSON(depName, fromVersion, newVersion) {
logger.info({ depName, fromVersion, newVersion }, 'No changelog found');
return null;
}
// Sort from oldest to newest
logger.debug({ res });
if (Array.isArray(res.versions)) {
res.versions.reverse();
res.versions.forEach(version => {
if (Array.isArray(version.changes)) {
version.changes.reverse();
}
});
}
await cacache.put(cachePath, cacheKey, JSON.stringify(res));
return res;
} catch (err) {

64
test/workers/pr/__snapshots__/changelog.spec.js.snap Normal file
View file

@ -0,0 +1,64 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP
exports[`workers/pr/changelog getChangeLogJSON sorts JSON 1`] = `
Object {
"project": Object {
"github": "chalk/chalk",
"repository": "https://github.com/chalk/chalk",
},
"versions": Array [
Object {
"changes": Array [
Object {
"date": "2017-10-22T08:20:23.000Z",
"message": "Add Awesome mentioned badge",
"sha": "4372d27f7eb887c4d33cdca1f9484f321ceab3dd",
},
Object {
"date": "2017-10-24T02:44:46.000Z",
"message": "Add .visible for emitting text only when enabled (fixes #192)",
"sha": "dc092b4a5f5ca77dd1e22607cdf2fdd388803064",
},
Object {
"date": "2017-10-24T02:46:10.000Z",
"message": "2.2.1",
"sha": "6adf5794a38552923ea474c4b60c372ef0582035",
},
Object {
"date": "2017-10-24T03:12:16.000Z",
"message": "add failing test for .visible bug",
"sha": "ede310303b9893146bd7cc24261a50e3b47c633a",
},
Object {
"date": "2017-10-24T03:12:34.000Z",
"message": "fix .visible when called after .enable is set to false",
"sha": "e2a4aa427568ff1c5d649739c4d1f8319cf0d072",
},
Object {
"date": "2017-10-24T03:15:51.000Z",
"message": "2.2.2",
"sha": "e1177ec3628f6d0d37489c1e1accd2c389a376a8",
},
],
"date": "2017-10-24T03:20:46.238Z",
"version": "2.2.2",
},
Object {
"changes": Array [
Object {
"date": "2017-10-24T04:02:36.000Z",
"message": "TypeScript fixes (#217)",
"sha": "7be154c074026f77b99e7d854b3a4cdd5e4ae502",
},
Object {
"date": "2017-10-24T04:12:53.000Z",
"message": "2.3.0",
"sha": "14e0aa97727019b22f0a003fdc631aeec5e2e24c",
},
],
"date": "2017-10-24T04:12:55.953Z",
"version": "2.3.0",
},
],
}
`;

67
test/workers/pr/changelog.spec.js
View file

@ -27,6 +27,73 @@ describe('workers/pr/changelog', () => {
await changelogHelper.getChangeLogJSON('renovate', '1.0.0', '2.0.0')
).toMatchObject({ a: 1 });
});
it('sorts JSON', async () => {
changelog.generate = jest.fn(() => ({
project: {
github: 'chalk/chalk',
repository: 'https://github.com/chalk/chalk',
},
versions: [
{
version: '2.3.0',
date: '2017-10-24T04:12:55.953Z',
changes: [
{
sha: '14e0aa97727019b22f0a003fdc631aeec5e2e24c',
date: '2017-10-24T04:12:53.000Z',
message: '2.3.0',
},
{
sha: '7be154c074026f77b99e7d854b3a4cdd5e4ae502',
date: '2017-10-24T04:02:36.000Z',
message: 'TypeScript fixes (#217)',
},
],
},
{
version: '2.2.2',
date: '2017-10-24T03:20:46.238Z',
changes: [
{
sha: 'e1177ec3628f6d0d37489c1e1accd2c389a376a8',
date: '2017-10-24T03:15:51.000Z',
message: '2.2.2',
},
{
sha: 'e2a4aa427568ff1c5d649739c4d1f8319cf0d072',
date: '2017-10-24T03:12:34.000Z',
message:
'fix .visible when called after .enable is set to false',
},
{
sha: 'ede310303b9893146bd7cc24261a50e3b47c633a',
date: '2017-10-24T03:12:16.000Z',
message: 'add failing test for .visible bug',
},
{
sha: '6adf5794a38552923ea474c4b60c372ef0582035',
date: '2017-10-24T02:46:10.000Z',
message: '2.2.1',
},
{
sha: 'dc092b4a5f5ca77dd1e22607cdf2fdd388803064',
date: '2017-10-24T02:44:46.000Z',
message:
'Add .visible for emitting text only when enabled (fixes #192)',
},
{
sha: '4372d27f7eb887c4d33cdca1f9484f321ceab3dd',
date: '2017-10-22T08:20:23.000Z',
message: 'Add Awesome mentioned badge',
},
],
},
],
}));
expect(
await changelogHelper.getChangeLogJSON('chalk', '2.2.2', '2.3.0')
).toMatchSnapshot();
});
it('returns cached JSON', async () => {
changelog.generate = jest.fn(() => ({ a: 2 }));
expect(