fix(manager:helmfile): add chart check (#11103)

lib/manager/helmfile/__fixtures__/multidoc.yaml

@@ -60,3 +60,5 @@ releases:
   needs:
     - manifests
   version: 13.7.2
+
+- name: invalid

lib/manager/helmfile/__snapshots__/extract.spec.ts.snap

@@ -22,6 +22,10 @@ Object {
         "https://prometheus-community.github.io/helm-charts",
       ],
     },
+    Object {
+      "depName": "invalid",
+      "skipReason": "invalid-name",
+    },
   ],
 }
 `;

lib/manager/helmfile/extract.spec.ts

@@ -1,5 +1,5 @@
 import { getName, loadFixture } from '../../../test/util';
-import { extractPackageFile } from './extract';
+import { extractPackageFile } from '.';
 
 const multidocYaml = loadFixture('multidoc.yaml');
 

lib/manager/helmfile/extract.ts

@@ -39,12 +39,19 @@ export function extractPackageFile(
       let depName = dep.chart;
       let repoName = null;
 
+      if (!is.string(dep.chart)) {
+        return {
+          depName: dep.name,
+          skipReason: SkipReason.InvalidName,
+        };
+      }
+
       // If starts with ./ is for sure a local path
       if (dep.chart.startsWith('./')) {
         return {
           depName,
-          skipReason: 'local-chart',
+          skipReason: SkipReason.LocalChart,
-        } as PackageDependency;
+        };
       }
 
       if (dep.chart.includes('/')) {

lib/manager/helmfile/types.ts

@@ -1,5 +1,6 @@
 export interface Doc {
   releases?: {
+    name: string;
     chart: string;
     version: string;
   }[];