renovate/renovate
1
0
Fork 0
mirror of https://github.com/renovatebot/renovate.git synced 2025-01-12 15:06:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

fix(gitlab): html formatting to fix details/summary

Browse source 
Fixes #2317
This commit is contained in:
Rhys Arkins 2018-07-27 19:49:56 +02:00
parent b932829060
commit a01b0b80ba
2 changed files with 15 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
lib/platform/gitlab/index.js
View file

@ -1,8 +1,13 @@
const is = require('@sindresorhus/is'); const is = require('@sindresorhus/is');
const addrs = require('email-addresses'); const addrs = require('email-addresses');
const showdown = require('showdown');
const get = require('./gl-got-wrapper'); const get = require('./gl-got-wrapper');
const endpoints = require('../../util/endpoints'); const endpoints = require('../../util/endpoints');
const converter = new showdown.Converter();
converter.setFlavor('github');
let config = {}; let config = {};
module.exports = { module.exports = {
@ -700,7 +705,15 @@ async function mergePr(iid) {
function getPrBody(input) { function getPrBody(input) {
// Convert to HTML using GitHub-flavoured markdown as it is more feature-rich than GitLab's flavour // Convert to HTML using GitHub-flavoured markdown as it is more feature-rich than GitLab's flavour
return input.replace(/Pull Request/g, 'Merge Request').replace(/PR/g, 'MR'); return converter
.makeHtml(input)
.replace(/Pull Request/g, 'Merge Request')
.replace(/PR/g, 'MR')
.replace(
`<p><details><br />\n<summary>Release Notes</summary></p>`,
'\n<details>\n\n<summary>Release Notes</summary>\n\n'
)
.replace('<p></details></p>', '\n</details>\n');
// TODO: set maximum length // TODO: set maximum length
} }

2
test/platform/gitlab/__snapshots__/index.spec.js.snap
View file

@ -243,7 +243,7 @@ Object {
} }
`; `;
exports[`platform/gitlab getPrBody(input) returns updated pr body 1`] = `"https://github.com/foo/bar/issues/5 plus also [a link](https://github.com/foo/bar/issues/5)"`; exports[`platform/gitlab getPrBody(input) returns updated pr body 1`] = `"<p><a href=\\"https://github.com/foo/bar/issues/5\\">https://github.com/foo/bar/issues/5</a> plus also <a href=\\"https://github.com/foo/bar/issues/5\\">a link</a></p>"`;
exports[`platform/gitlab getPrFiles() returns files 1`] = ` exports[`platform/gitlab getPrFiles() returns files 1`] = `
Array [ Array [