renovate/renovate
1
0
Fork 0
mirror of https://github.com/renovatebot/renovate.git synced 2025-01-12 15:06:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

feat(npm): support password auth npmrc rules (#8967)

Browse source 
Co-authored-by: Rhys Arkins <rhys@arkins.net>
This commit is contained in:
Michael Kriese 2021-03-05 09:39:12 +01:00 committed by GitHub
parent a986b01aa2
commit a83f28dc77
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 21 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
docs/usage/private-modules.md
View file

@ -41,7 +41,7 @@ The recommended approaches in order of preference are:
All the various approaches are described below:
### Commit .npmrc file into repository
### Add hostRule to bots config
Define `hostRules` like this:
@ -51,7 +51,14 @@ module.exports = {
{
hostType: 'npm',
hostName: 'registry.npmjs.org',
token: 'abc123',
token: process.env.NPM_TOKEN,
},
{
hostType: 'npm',
baseUrl:
'https://pkgs.dev.azure.com/{organization}/_packaging/{feed}/npm/registry/',
username: 'VssSessionToken',
password: process.env.AZURE_NPM_TOKEN,
},
],
};
@ -67,6 +74,8 @@ If Renovate detects a `.npmrc` or `.yarnrc` file then it will use it for its ins
Does not work if using binarySource=docker.
**This method will be deprecated soon**
### Add npmrc string to Renovate config
The above solution maybe have a downside that all users of the repository (e.g. developers) will also use any `.npmrc` that is checked into the repository, instead of their own one in `~/.npmrc`.

10
lib/manager/npm/post-update/index.ts
View file

@ -466,6 +466,16 @@ export async function getAdditionalFiles(
`//${hostRule.hostName}/:_authToken=${hostRule.token}`
);
}
} else if (is.string(hostRule.username) && is.string(hostRule.password)) {
if (hostRule.baseUrl) {
const uri = hostRule.baseUrl.replace(/^https?:/, '');
additionalNpmrcContent.push(`${uri}:username=${hostRule.username}`);
additionalNpmrcContent.push(`${uri}:_password=${hostRule.password}`);
} else if (hostRule.hostName) {
const uri = `//${hostRule.hostName}/`;
additionalNpmrcContent.push(`${uri}:username=${hostRule.username}`);
additionalNpmrcContent.push(`${uri}:_password=${hostRule.password}`);
}
}
}