chore: fix more eslint warnings (#7001)

lib/datasource/rubygems/get.ts

@@ -14,7 +14,11 @@ const getHeaders = (): OutgoingHttpHeaders => {
   return { hostType: id };
 };
 
-const fetch = async ({ dependency, registry, path }): Promise<any> => {
+export async function fetch(
+  dependency: string,
+  registry: string,
+  path: string
+): Promise<any> {
   const headers = getHeaders();
 
   const name = `${path}/${dependency}.json`;
@@ -26,14 +30,14 @@ const fetch = async ({ dependency, registry, path }): Promise<any> => {
   };
 
   return response.body;
-};
+}
 
-export const getDependency = async ({
+export async function getDependency(
-  dependency,
+  dependency: string,
-  registry,
+  registry: string
-}): Promise<ReleaseResult | null> => {
+): Promise<ReleaseResult | null> {
   logger.debug({ dependency }, 'RubyGems lookup for dependency');
-  const info = await fetch({ dependency, registry, path: INFO_PATH });
+  const info = await fetch(dependency, registry, INFO_PATH);
   if (!info) {
     logger.debug({ dependency }, 'RubyGems package not found.');
     return null;
@@ -47,8 +51,7 @@ export const getDependency = async ({
     return null;
   }
 
-  const versions =
+  const versions = (await fetch(dependency, registry, VERSIONS_PATH)) || [];
-    (await fetch({ dependency, registry, path: VERSIONS_PATH })) || [];
 
   const releases = versions.map(
     ({
@@ -72,4 +75,4 @@ export const getDependency = async ({
     sourceUrl: info.source_code_uri,
     changelogUrl: info.changelog_uri,
   };
-};
+}

lib/datasource/rubygems/releases.ts

@@ -10,5 +10,5 @@ export function getReleases({
   if (registryUrl.endsWith('rubygems.org')) { // lgtm [js/incomplete-url-substring-sanitization]
       return getRubygemsOrgDependency(lookupName);
     }
-  return getDependency({ dependency: lookupName, registry: registryUrl });
+  return getDependency(lookupName, registryUrl);
 }

lib/logger/err-serializer.ts

@@ -2,7 +2,7 @@ import is from '@sindresorhus/is';
 
 Error.stackTraceLimit = 20;
 
-// TODO: remove any type
+// eslint-disable-next-lint @typescript-eslint/explicit-module-boundary-types
 export default function errSerializer(err: any): any {
   const response = {
     ...err,

lib/logger/index.ts

@@ -111,11 +111,13 @@ export function getContext(): any {
 }
 
 // setMeta overrides existing meta, may remove fields if no longer existing
+// eslint-disable-next-lint @typescript-eslint/explicit-module-boundary-types
 export function setMeta(obj: any): void {
   meta = { ...obj };
 }
 
 // addMeta overrides or adds fields but does not remove any
+// eslint-disable-next-lint @typescript-eslint/explicit-module-boundary-types
 export function addMeta(obj: any): void {
   meta = { ...meta, ...obj };
 }

lib/logger/utils.ts

@@ -92,6 +92,8 @@ function sanitizeValue(value: any, seen = new WeakMap()): any {
   return valueType === 'string' ? sanitize(value) : value;
 }
 
+// TODO
+// eslint-disable-next-lint @typescript-eslint/explicit-module-boundary-types
 export function withSanitizer(streamConfig): bunyan.Stream {
   if (streamConfig.type === 'rotating-file') {
     throw new Error("Rotating files aren't supported");

lib/platform/bitbucket-server/index.ts

@@ -308,11 +308,10 @@ const isRelevantPr = (
   matchesState(p.state, state);
 
 // TODO: coverage
-// eslint-disable-next-line @typescript-eslint/no-unused-vars
+export async function getPrList(refreshCache?: boolean): Promise<Pr[]> {
-export async function getPrList(_args?: any): Promise<Pr[]> {
   logger.debug(`getPrList()`);
   // istanbul ignore next
-  if (!config.prList) {
+  if (!config.prList || refreshCache) {
     const query = new URLSearchParams({
       state: 'ALL',
       'role.1': 'AUTHOR',
@@ -339,7 +338,7 @@ export async function findPr({
   refreshCache,
 }: FindPRConfig): Promise<Pr | null> {
   logger.debug(`findPr(${branchName}, "${prTitle}", "${state}")`);
-  const prList = await getPrList({ refreshCache });
+  const prList = await getPrList(refreshCache);
   const pr = prList.find(isRelevantPr(branchName, prTitle, state));
   if (pr) {
     logger.debug(`Found PR #${pr.number}`);