From c34e54c5d3dec37cfb799a6f3b7fb5c22de599d7 Mon Sep 17 00:00:00 2001 From: Rhys Arkins Date: Thu, 18 Feb 2021 08:24:08 +0100 Subject: [PATCH] refactor: remove SkipVersion.UnsupportedValue --- lib/manager/terraform/__snapshots__/extract.spec.ts.snap | 2 +- lib/manager/terraform/resources.ts | 2 +- lib/types/skip-reason.ts | 1 - .../process/lookup/__snapshots__/index.spec.ts.snap | 4 ++-- lib/workers/repository/process/lookup/index.ts | 4 ++-- 5 files changed, 6 insertions(+), 7 deletions(-) diff --git a/lib/manager/terraform/__snapshots__/extract.spec.ts.snap b/lib/manager/terraform/__snapshots__/extract.spec.ts.snap index 7b992a69ed..e8baaac71d 100644 --- a/lib/manager/terraform/__snapshots__/extract.spec.ts.snap +++ b/lib/manager/terraform/__snapshots__/extract.spec.ts.snap @@ -345,7 +345,7 @@ Object { "skipReason": "invalid-dependency-specification", }, Object { - "skipReason": "unsupported-value", + "skipReason": "invalid-value", }, ], } diff --git a/lib/manager/terraform/resources.ts b/lib/manager/terraform/resources.ts index fe752f612b..8d7a56b53d 100644 --- a/lib/manager/terraform/resources.ts +++ b/lib/manager/terraform/resources.ts @@ -107,7 +107,7 @@ export function analyseTerraformResource( break; default: - dep.skipReason = SkipReason.UnsupportedValue; + dep.skipReason = SkipReason.InvalidValue; break; } /* eslint-enable no-param-reassign */ diff --git a/lib/types/skip-reason.ts b/lib/types/skip-reason.ts index ce9a643a36..d6d0baee5c 100644 --- a/lib/types/skip-reason.ts +++ b/lib/types/skip-reason.ts @@ -36,7 +36,6 @@ export enum SkipReason { UnsupportedChartType = 'unsupported-chart-type', UnsupportedRemote = 'unsupported-remote', UnsupportedUrl = 'unsupported-url', - UnsupportedValue = 'unsupported-value', UnsupportedVersion = 'unsupported-version', Unsupported = 'unsupported', UnversionedReference = 'unversioned-reference', diff --git a/lib/workers/repository/process/lookup/__snapshots__/index.spec.ts.snap b/lib/workers/repository/process/lookup/__snapshots__/index.spec.ts.snap index fbc2b49113..1a7db8c159 100644 --- a/lib/workers/repository/process/lookup/__snapshots__/index.spec.ts.snap +++ b/lib/workers/repository/process/lookup/__snapshots__/index.spec.ts.snap @@ -1354,7 +1354,7 @@ Object { exports[`workers/repository/process/lookup .lookupUpdates() skips undefined values 1`] = ` Object { - "skipReason": "unsupported-value", + "skipReason": "invalid-value", "updates": Array [], "warnings": Array [], } @@ -1362,7 +1362,7 @@ Object { exports[`workers/repository/process/lookup .lookupUpdates() skips unsupported values 1`] = ` Object { - "skipReason": "unsupported-value", + "skipReason": "invalid-value", "updates": Array [], "warnings": Array [], } diff --git a/lib/workers/repository/process/lookup/index.ts b/lib/workers/repository/process/lookup/index.ts index 013130c0fc..8d4aad660d 100644 --- a/lib/workers/repository/process/lookup/index.ts +++ b/lib/workers/repository/process/lookup/index.ts @@ -401,11 +401,11 @@ export async function lookupUpdates( res.updates.push(update); } } else if (!currentValue) { - res.skipReason = SkipReason.UnsupportedValue; + res.skipReason = SkipReason.InvalidValue; } else { logger.debug(`Dependency ${depName} has unsupported value ${currentValue}`); if (!config.pinDigests && !config.currentDigest) { - res.skipReason = SkipReason.UnsupportedValue; + res.skipReason = SkipReason.InvalidValue; } else { delete res.skipReason; }