renovate/renovate
1
0
Fork 0
mirror of https://github.com/renovatebot/renovate.git synced 2025-01-11 22:46:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

fix(maven): Catch and log URL construction errors (#4572)

Browse source
This commit is contained in:
Sergio Zharinov 2019-10-03 00:26:45 +04:00 committed by Rhys Arkins
parent ecdb9b3c3b
commit e67523e152
2 changed files with 22 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
lib/datasource/maven/index.ts
View file

@ -91,10 +91,19 @@ async function downloadMavenXml(
repoUrl: string,
dependencyFilePath: string
): Promise<XmlDocument | null> {
const pkgUrl = new url.URL(
`${dependency.dependencyUrl}/${dependencyFilePath}`,
repoUrl
);
let pkgUrl;
try {
pkgUrl = new url.URL(
`${dependency.dependencyUrl}/${dependencyFilePath}`,
repoUrl
);
} catch (err) {
logger.debug(
{ err, dependency, repoUrl, dependencyFilePath },
`Error constructing URL for ${dependency.display}`
);
return null;
}
let rawContent: string;
switch (pkgUrl.protocol) {

10
test/datasource/maven.spec.ts
View file

@ -215,7 +215,15 @@ describe('datasource/maven', () => {
});
expect(releases).toBeNull();
});
it('should return null for invalid registryUrls', async () => {
const releases = await datasource.getPkgReleases({
...config,
lookupName: 'mysql:mysql-connector-java',
// eslint-disable-next-line no-template-curly-in-string
registryUrls: ['${project.baseUri}../../repository/'],
});
expect(releases).toBeNull();
});
it('should support scm.url values prefixed with "scm:"', async () => {
const releases = await datasource.getPkgReleases({
...config,