Commit graph

2 commits

Author SHA1 Message Date
Michael Kriese
d71b1ec92c
fix: rethrow ExternalHostError error (#10761) 2021-07-09 07:06:50 +00:00
Jamie Magee
621b77b2c7
refactor(datasource): migrate to class based datasource (#6747)
* refactor(datasource): migrate to class based datasource

    A small experiment into what OOP/class based datasources might look like. Picked Cdnjs as it's the smallest & simplest.

    With this approach we can share common logic, like error handling, rate limiting, etc. between different datasources, instead of having to reimplement it each time we write a new datasource. Currently there's nothing shared, as it's only 1 datasource, but the interesting stuff will come with the 2nd datasource

* Apply suggestions from code review

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>

* remove renaming ClojureDatasource to datasource in tests

Co-authored-by: Rhys Arkins <rhys@arkins.net>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
2021-05-21 07:40:09 +02:00