mirror of
https://github.com/renovatebot/renovate.git
synced 2025-01-12 15:06:27 +00:00
7f4cb4aa57
This PR replaces the existing `pinVersions`, `upgradeInRange` and `versionStrategy` settings with a single one: `rangeStrategy`. Previously: - `pinVersions` could be `true` or `false`, but defaulted to `null`, which meant that Renovate would decide. `true` meant that Renovate would replace existing ranges like `^1.0.0` with an exact/pinned version such as `1.2.0`. - `upgradeInRange` could be true or false, default to false. If `true`, it would mean Renovate would replace an existing range like `^1.0.0` with something like `^1.2.0` - `versionStrategy` could be `replace` or `widen` and was mainly used for `peerDependencies` to widen existing ranges, e.g. from `^1.0.0` to `^1.0.0 || ^2.0.0` It was possible to set conflicting settings, e.g. configuring `pinVersions=true` and `upgradeInRange=true`. Now, we combine them into a single setting: `rangeStrategy`: - `auto` = Renovate decides (this will be done on a manager-by-manager basis) - `pin` = convert ranges to exact versions - `bump` = same as `upgradeInRange` previously, e.g. bump the range even if the new version satisifies the existing range - `replace` = Same as pinVersions === false && upgradeInRange === false, i.e. only replace the range if the new version falls outside it - `widen` = Same as previous versionStrategy==='widen'
356 lines
11 KiB
JavaScript
356 lines
11 KiB
JavaScript
const npm = require('../../lib/datasource/npm');
|
|
const presets = require('../../lib/config/presets');
|
|
const presetDefaults = require('../_fixtures/npm/renovate-config-default');
|
|
const presetPackages = require('../_fixtures/npm/renovate-config-packages');
|
|
const presetGroup = require('../_fixtures/npm/renovate-config-group');
|
|
const presetMonorepo = require('../_fixtures/npm/renovate-config-monorepo');
|
|
const presetIkatyang = require('../_fixtures/npm/renovate-config-ikatyang');
|
|
|
|
npm.getDependency = jest.fn(dep => {
|
|
if (dep === 'renovate-config-default') {
|
|
return {
|
|
'renovate-config':
|
|
presetDefaults.versions[presetDefaults['dist-tags'].latest][
|
|
'renovate-config'
|
|
],
|
|
};
|
|
}
|
|
if (dep === 'renovate-config-packages') {
|
|
return {
|
|
'renovate-config':
|
|
presetPackages.versions[presetPackages['dist-tags'].latest][
|
|
'renovate-config'
|
|
],
|
|
};
|
|
}
|
|
if (dep === 'renovate-config-group') {
|
|
return {
|
|
'renovate-config':
|
|
presetGroup.versions[presetGroup['dist-tags'].latest][
|
|
'renovate-config'
|
|
],
|
|
};
|
|
}
|
|
if (dep === 'renovate-config-ikatyang') {
|
|
return {
|
|
'renovate-config':
|
|
presetIkatyang.versions[presetIkatyang['dist-tags'].latest][
|
|
'renovate-config'
|
|
],
|
|
};
|
|
}
|
|
if (dep === 'renovate-config-monorepo') {
|
|
return {
|
|
'renovate-config':
|
|
presetMonorepo.versions[presetMonorepo['dist-tags'].latest][
|
|
'renovate-config'
|
|
],
|
|
};
|
|
}
|
|
if (dep === 'renovate-config-noconfig') {
|
|
return {};
|
|
}
|
|
if (dep === 'renovate-config-throw') {
|
|
throw new Error('whoops');
|
|
}
|
|
if (dep === 'renovate-config-wrongpreset') {
|
|
return {
|
|
'renovate-config': {},
|
|
};
|
|
}
|
|
return null;
|
|
});
|
|
|
|
describe('config/presets', () => {
|
|
describe('resolvePreset', () => {
|
|
let config;
|
|
beforeEach(() => {
|
|
config = {};
|
|
});
|
|
it('returns same if no presets', async () => {
|
|
config.foo = 1;
|
|
config.extends = [];
|
|
const res = await presets.resolveConfigPresets(config);
|
|
expect(config).toMatchObject(res);
|
|
expect(res).toMatchSnapshot();
|
|
});
|
|
it('throws if invalid preset file', async () => {
|
|
config.foo = 1;
|
|
config.extends = ['notfoundaaaaaaaa'];
|
|
let e;
|
|
try {
|
|
await presets.resolveConfigPresets(config);
|
|
} catch (err) {
|
|
e = err;
|
|
}
|
|
expect(e).toBeDefined();
|
|
expect(e.configFile).toMatchSnapshot();
|
|
expect(e.validationError).toMatchSnapshot();
|
|
expect(e.validationMessage).toMatchSnapshot();
|
|
});
|
|
it('throws if invalid preset', async () => {
|
|
config.foo = 1;
|
|
config.extends = [':invalid-preset'];
|
|
let e;
|
|
try {
|
|
await presets.resolveConfigPresets(config);
|
|
} catch (err) {
|
|
e = err;
|
|
}
|
|
expect(e).toBeDefined();
|
|
expect(e.configFile).toMatchSnapshot();
|
|
expect(e.validationError).toMatchSnapshot();
|
|
expect(e.validationMessage).toMatchSnapshot();
|
|
});
|
|
it('works with valid', async () => {
|
|
config.foo = 1;
|
|
config.extends = [':pinVersions'];
|
|
const res = await presets.resolveConfigPresets(config);
|
|
expect(res).toMatchSnapshot();
|
|
expect(res.rangeStrategy).toEqual('pin');
|
|
});
|
|
it('throws if valid and invalid', async () => {
|
|
config.foo = 1;
|
|
config.extends = [':invalid-preset', ':pinVersions'];
|
|
let e;
|
|
try {
|
|
await presets.resolveConfigPresets(config);
|
|
} catch (err) {
|
|
e = err;
|
|
}
|
|
expect(e).toBeDefined();
|
|
expect(e.configFile).toMatchSnapshot();
|
|
expect(e.validationError).toMatchSnapshot();
|
|
expect(e.validationMessage).toMatchSnapshot();
|
|
});
|
|
it('resolves group monorepos', async () => {
|
|
config.extends = ['group:monorepos'];
|
|
const res = await presets.resolveConfigPresets(config);
|
|
expect(res).toMatchSnapshot();
|
|
});
|
|
it('combines two package alls', async () => {
|
|
config.extends = ['packages:eslint', 'packages:stylelint'];
|
|
const res = await presets.resolveConfigPresets(config);
|
|
expect(res).toMatchSnapshot();
|
|
});
|
|
it('resolves packageRule', async () => {
|
|
config.packageRules = [
|
|
{
|
|
extends: ['packages:eslint'],
|
|
groupName: 'eslint',
|
|
},
|
|
];
|
|
const res = await presets.resolveConfigPresets(config);
|
|
expect(res).toMatchSnapshot();
|
|
});
|
|
it('resolves eslint', async () => {
|
|
config.extends = ['packages:eslint'];
|
|
const res = await presets.resolveConfigPresets(config);
|
|
expect(res).toMatchSnapshot();
|
|
expect(res.packagePatterns).toHaveLength(1);
|
|
});
|
|
it('resolves linters', async () => {
|
|
config.extends = ['packages:linters'];
|
|
const res = await presets.resolveConfigPresets(config);
|
|
expect(res).toMatchSnapshot();
|
|
expect(res.packageNames).toHaveLength(1);
|
|
expect(res.packagePatterns).toHaveLength(2);
|
|
});
|
|
it('resolves nested groups', async () => {
|
|
config.extends = [':automergeLinters'];
|
|
const res = await presets.resolveConfigPresets(config);
|
|
expect(res).toMatchSnapshot();
|
|
const rule = res.packageRules[0];
|
|
expect(rule.automerge).toEqual(true);
|
|
expect(rule.packageNames).toHaveLength(1);
|
|
expect(rule.packagePatterns).toHaveLength(2);
|
|
});
|
|
it('migrates automerge in presets', async () => {
|
|
config.extends = ['ikatyang:library'];
|
|
const res = await presets.resolveConfigPresets(config);
|
|
expect(res).toMatchSnapshot();
|
|
expect(res.automerge).not.toBeDefined();
|
|
expect(res.minor.automerge).toBe(true);
|
|
});
|
|
});
|
|
describe('replaceArgs', () => {
|
|
const argMappings = {
|
|
arg0: 'a',
|
|
arg1: 'b',
|
|
arg2: 'c',
|
|
};
|
|
it('replaces args in strings', () => {
|
|
const str = '{{arg2}} foo {{arg0}}{{arg1}}';
|
|
const res = presets.replaceArgs(str, argMappings);
|
|
expect(res).toMatchSnapshot();
|
|
});
|
|
it('replaces args twice in same string', () => {
|
|
const str = '{{arg2}}{{arg0}} foo {{arg0}}{{arg1}}';
|
|
const res = presets.replaceArgs(str, argMappings);
|
|
expect(res).toEqual('ca foo ab');
|
|
});
|
|
it('replaces objects', () => {
|
|
const obj = {
|
|
foo: 'ha {{arg0}}',
|
|
bar: {
|
|
baz: '{{arg1}} boo',
|
|
aaa: {
|
|
bbb: 'woo {{arg2}}',
|
|
},
|
|
},
|
|
};
|
|
const res = presets.replaceArgs(obj, argMappings);
|
|
expect(res).toMatchSnapshot();
|
|
});
|
|
it('replaces arrays', () => {
|
|
const obj = {
|
|
foo: [
|
|
'{{arg0}}',
|
|
{
|
|
bar: '{{arg1}}',
|
|
baz: 5,
|
|
},
|
|
],
|
|
};
|
|
const res = presets.replaceArgs(obj, argMappings);
|
|
expect(res).toMatchSnapshot();
|
|
});
|
|
});
|
|
describe('parsePreset', () => {
|
|
// default namespace
|
|
it('returns default package name', () => {
|
|
expect(presets.parsePreset(':base')).toMatchSnapshot();
|
|
});
|
|
it('returns default package name with params', () => {
|
|
expect(
|
|
presets.parsePreset(':group(packages/eslint, eslint)')
|
|
).toMatchSnapshot();
|
|
});
|
|
// scoped namespace
|
|
it('returns simple scope', () => {
|
|
expect(presets.parsePreset('@somescope')).toMatchSnapshot();
|
|
});
|
|
it('returns simple scope and params', () => {
|
|
expect(presets.parsePreset('@somescope(param1)')).toMatchSnapshot();
|
|
});
|
|
it('returns scope with packageName and default', () => {
|
|
expect(
|
|
presets.parsePreset('@somescope/somepackagename')
|
|
).toMatchSnapshot();
|
|
});
|
|
it('returns scope with packageName and params and default', () => {
|
|
expect(
|
|
presets.parsePreset(
|
|
'@somescope/somepackagename(param1, param2, param3)'
|
|
)
|
|
).toMatchSnapshot();
|
|
});
|
|
it('returns scope with presetName', () => {
|
|
expect(
|
|
presets.parsePreset('@somescope:somePresetName')
|
|
).toMatchSnapshot();
|
|
});
|
|
it('returns scope with presetName and params', () => {
|
|
expect(
|
|
presets.parsePreset('@somescope:somePresetName(param1)')
|
|
).toMatchSnapshot();
|
|
});
|
|
it('returns scope with packageName and presetName', () => {
|
|
expect(
|
|
presets.parsePreset('@somescope/somepackagename:somePresetName')
|
|
).toMatchSnapshot();
|
|
});
|
|
it('returns scope with packageName and presetName and params', () => {
|
|
expect(
|
|
presets.parsePreset(
|
|
'@somescope/somepackagename:somePresetName(param1, param2)'
|
|
)
|
|
).toMatchSnapshot();
|
|
});
|
|
// non-scoped namespace
|
|
it('returns non-scoped default', () => {
|
|
expect(presets.parsePreset('somepackage')).toMatchSnapshot();
|
|
});
|
|
it('returns non-scoped package name', () => {
|
|
expect(presets.parsePreset('somepackage:webapp')).toMatchSnapshot();
|
|
});
|
|
it('returns non-scoped package name full', () => {
|
|
expect(
|
|
presets.parsePreset('renovate-config-somepackage:webapp')
|
|
).toMatchSnapshot();
|
|
});
|
|
it('returns non-scoped package name with params', () => {
|
|
expect(
|
|
presets.parsePreset('somepackage:webapp(param1)')
|
|
).toMatchSnapshot();
|
|
});
|
|
});
|
|
describe('getPreset', () => {
|
|
it('gets linters', async () => {
|
|
const res = await presets.getPreset('packages:linters');
|
|
expect(res).toMatchSnapshot();
|
|
expect(res.packageNames).toHaveLength(1);
|
|
expect(res.extends).toHaveLength(2);
|
|
});
|
|
it('gets parameterised configs', async () => {
|
|
const res = await presets.getPreset(':group(packages:eslint, eslint)');
|
|
expect(res).toMatchSnapshot();
|
|
});
|
|
it('handles missing params', async () => {
|
|
const res = await presets.getPreset(':group()');
|
|
expect(res).toMatchSnapshot();
|
|
});
|
|
it('ignores irrelevant params', async () => {
|
|
const res = await presets.getPreset(':pinVersions(foo, bar)');
|
|
expect(res).toMatchSnapshot();
|
|
});
|
|
it('handles 404 packages', async () => {
|
|
let e;
|
|
try {
|
|
await presets.getPreset('notfound:foo');
|
|
} catch (err) {
|
|
e = err;
|
|
}
|
|
expect(e).toBeDefined();
|
|
expect(e.configFile).toMatchSnapshot();
|
|
expect(e.validationError).toMatchSnapshot();
|
|
expect(e.validationMessage).toMatchSnapshot();
|
|
});
|
|
it('handles no config', async () => {
|
|
let e;
|
|
try {
|
|
await presets.getPreset('noconfig:foo');
|
|
} catch (err) {
|
|
e = err;
|
|
}
|
|
expect(e).toBeDefined();
|
|
expect(e.configFile).toMatchSnapshot();
|
|
expect(e.validationError).toMatchSnapshot();
|
|
expect(e.validationMessage).toMatchSnapshot();
|
|
});
|
|
it('handles throw errors', async () => {
|
|
let e;
|
|
try {
|
|
await presets.getPreset('throw:foo');
|
|
} catch (err) {
|
|
e = err;
|
|
}
|
|
expect(e).toBeDefined();
|
|
expect(e.configFile).toMatchSnapshot();
|
|
expect(e.validationError).toMatchSnapshot();
|
|
expect(e.validationMessage).toMatchSnapshot();
|
|
});
|
|
it('handles preset not found', async () => {
|
|
let e;
|
|
try {
|
|
await presets.getPreset('wrongpreset:foo');
|
|
} catch (err) {
|
|
e = err;
|
|
}
|
|
expect(e).toBeDefined();
|
|
expect(e.configFile).toMatchSnapshot();
|
|
expect(e.validationError).toMatchSnapshot();
|
|
expect(e.validationMessage).toMatchSnapshot();
|
|
});
|
|
});
|
|
});
|